Order has one param without spaces #5203
Conversation
from http://httpd.apache.org/docs/current/mod/mod_access_compat.html#order "Ordering is one of: Allow,Deny First, all Allow directives are evaluated; at least one must match, or the request is rejected. Next, all Deny directives are evaluated. If any matches, the request is rejected. Last, any requests which do not match an Allow or a Deny directive are denied by default. Deny,Allow First, all Deny directives are evaluated; if any match, the request is denied unless it also matches an Allow directive. Any requests which do not match any Allow or Deny directives are permitted. Mutual-failure This order has the same effect as Order Allow,Deny and is deprecated in its favor."
|
👍 😊 |
|
@carlosbuenosvinos thanks for fixing this issue and for providing the reference documentation. I have a minor question: given how strict Apache is with white spaces, should we also use |
|
Thank you for noticing and for providing a patch @carlosbuenosvinos. However, someone was already faster. So I'm going to close this in favor of #5197. |
|
"Directives in the configuration files are case-insensitive, but arguments to directives are often case sensitive", however, in case of order, for me it works on every server. I'll fix it thought. |
|
You were too fast, I fixed Allow,Deny case too. But, up to you :) |
|
Thank you Carlos. I decided to merge this one as this had both fixes (removed space and a capitialized value). Great job! |
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #5203). Discussion ---------- Order has one param without spaces | Q | A | ----------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | none from http://httpd.apache.org/docs/current/mod/mod_access_compat.html#order "Ordering is one of: Allow,Deny First, all Allow directives are evaluated; at least one must match, or the request is rejected. Next, all Deny directives are evaluated. If any matches, the request is rejected. Last, any requests which do not match an Allow or a Deny directive are denied by default. Deny,Allow First, all Deny directives are evaluated; if any match, the request is denied unless it also matches an Allow directive. Any requests which do not match any Allow or Deny directives are permitted. Mutual-failure This order has the same effect as Order Allow,Deny and is deprecated in its favor." Commits ------- fe77d49 Order has one param without spaces
|
You welcome |
from http://httpd.apache.org/docs/current/mod/mod_access_compat.html#order
"Ordering is one of:
Allow,Deny
First, all Allow directives are evaluated; at least one must match, or the request is rejected. Next, all Deny directives are evaluated. If any matches, the request is rejected. Last, any requests which do not match an Allow or a Deny directive are denied by default.
Deny,Allow
First, all Deny directives are evaluated; if any match, the request is denied unless it also matches an Allow directive. Any requests which do not match any Allow or Deny directives are permitted.
Mutual-failure
This order has the same effect as Order Allow,Deny and is deprecated in its favor."