-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lots of minor fixes & applying best practices to form cookbook doc #6050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Q | A | ------------- | --- | Doc fix? | [yes] | New docs? | [no] | Applies to | [2.3] | Fixed tickets | []
| Q | A | ------------- | --- | Doc fix? | [yes] | New docs? | [yes] | Applies to | [2.3] | Fixed tickets | []
| Q | A | ------------- | --- | Doc fix? | [yes] | New docs? | [no] | Applies to | [2.3] | Fixed tickets | [] I guess it's not necessary to do anything in __construct manually - the ArrayCollection is automatically initialized when you do php app/console doctrine:generate:entities AppBundle Please double-check!
| Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 | Fixed tickets |
| Q | A | ------------- | --- | Doc fix? | [yes] | New docs? | [no] | Applies to | [2.3] | Fixed tickets |[]
| Q | A | ------------- | --- | Doc fix? | [yes] | New docs? | [no] | Applies to | [2.3] | Fixed tickets | []
| Q | A | ------------- | --- | Doc fix? | [yes] | New docs? | [no] | Applies to | [2.3] | Fixed tickets | []
"app/Resources/views/Form/fields.html.twig" didn't work for me - see next code block: "form_theme form 'AppBundle:Form:fields.html.twig'" If this change is correct, I guess it needs to be corrected multiple times on this page.
"the form" sounded like the HTML form. | Q | A | ------------- | --- | Doc fix? | [yes] | New docs? | [no] | Applies to | [2.3] | Fixed tickets | []
👍 nice! |
Closed
Thank you @ThomasLandauer and @wouterj. |
xabbuh
added a commit
that referenced
this pull request
Dec 23, 2015
…kbook doc (ThomasLandauer, WouterJ) This PR was merged into the 2.3 branch. Discussion ---------- Lots of minor fixes & applying best practices to form cookbook doc This finishes #5569 | Q | A | --- | --- | doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | - Commits ------- 99cdc00 Revert some changes and fix template names 2b00abe Minor clarification 3ce46f6 Fixed file path d227ffb Fixed typo 44d19de Added example for 'required' => false ebb1e74 Update templating.rst d806300 Typo: Removed comma 6e41f57 Another typo a4f0318 Fixed typo 275c079 Removed unnecessary(?) YAML hint 9cd391b Note about nesting blocks and {% endblock NAME %} 41f7e6f Changed <meta http-equiv> to HTML5's <meta charset>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finishes #5569