Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lots of minor fixes & applying best practices to form cookbook doc #6050

Merged
merged 12 commits into from
Dec 23, 2015
Merged

Lots of minor fixes & applying best practices to form cookbook doc #6050

merged 12 commits into from
Dec 23, 2015

Commits on Dec 19, 2015

  1. Changed <meta http-equiv> to HTML5's <meta charset> 

    | Q             | A
| ------------- | ---
| Doc fix?      | [yes]
| New docs?     | [no]
| Applies to    | [2.3]
| Fixed tickets | []
    @ThomasLandauer @wouterj
    ThomasLandauer authored and wouterj committed Dec 19, 2015
    Configuration menu
    Copy the full SHA
    41f7e6f View commit details
    Browse the repository at this point in the history

  2. Note about nesting blocks and {% endblock NAME %} 

    | Q             | A
| ------------- | ---
| Doc fix?      | [yes]
| New docs?     | [yes] 
| Applies to    | [2.3]
| Fixed tickets | []
    @ThomasLandauer @wouterj
    ThomasLandauer authored and wouterj committed Dec 19, 2015
    Configuration menu
    Copy the full SHA
    9cd391b View commit details
    Browse the repository at this point in the history

  3. Removed unnecessary(?) YAML hint 

    | Q             | A
| ------------- | ---
| Doc fix?      | [yes]
| New docs?     | [no]
| Applies to    | [2.3]
| Fixed tickets | []

I guess it's not necessary to do anything in __construct manually - the ArrayCollection is automatically initialized when you do php app/console doctrine:generate:entities AppBundle

Please double-check!
    @ThomasLandauer @wouterj
    ThomasLandauer authored and wouterj committed Dec 19, 2015
    Configuration menu
    Copy the full SHA
    275c079 View commit details
    Browse the repository at this point in the history

  4. Fixed typo 

    | Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3
| Fixed tickets |
    @ThomasLandauer @wouterj
    ThomasLandauer authored and wouterj committed Dec 19, 2015
    Configuration menu
    Copy the full SHA
    a4f0318 View commit details
    Browse the repository at this point in the history

  5. Another typo

    @ThomasLandauer @wouterj
    ThomasLandauer authored and wouterj committed Dec 19, 2015
    Configuration menu
    Copy the full SHA
    6e41f57 View commit details
    Browse the repository at this point in the history

  6. Typo: Removed comma 

    | Q             | A
| ------------- | ---
| Doc fix?      | [yes]
| New docs?     | [no]
| Applies to    | [2.3]
| Fixed tickets |[]
    @ThomasLandauer @wouterj
    ThomasLandauer authored and wouterj committed Dec 19, 2015
    Configuration menu
    Copy the full SHA
    d806300 View commit details
    Browse the repository at this point in the history

  7. Update templating.rst

    @ThomasLandauer @wouterj
    ThomasLandauer authored and wouterj committed Dec 19, 2015
    Configuration menu
    Copy the full SHA
    ebb1e74 View commit details
    Browse the repository at this point in the history

  8. Added example for 'required' => false 

    | Q             | A
| ------------- | ---
| Doc fix?      | [yes]
| New docs?     | [no]
| Applies to    | [2.3]
| Fixed tickets | []
    @ThomasLandauer @wouterj
    ThomasLandauer authored and wouterj committed Dec 19, 2015
    Configuration menu
    Copy the full SHA
    44d19de View commit details
    Browse the repository at this point in the history

  9. Fixed typo 

    | Q             | A
| ------------- | ---
| Doc fix?      | [yes]
| New docs?     | [no]
| Applies to    | [2.3]
| Fixed tickets | []
    @ThomasLandauer @wouterj
    ThomasLandauer authored and wouterj committed Dec 19, 2015
    Configuration menu
    Copy the full SHA
    d227ffb View commit details
    Browse the repository at this point in the history

  10. Fixed file path 

    "app/Resources/views/Form/fields.html.twig" didn't work for me - see next code block: "form_theme form 'AppBundle:Form:fields.html.twig'"

If this change is correct, I guess it needs to be corrected multiple times on this page.
    @ThomasLandauer @wouterj
    ThomasLandauer authored and wouterj committed Dec 19, 2015
    Configuration menu
    Copy the full SHA
    3ce46f6 View commit details
    Browse the repository at this point in the history

  11. Minor clarification 

    "the form" sounded like the HTML form.

| Q             | A
| ------------- | ---
| Doc fix?      | [yes]
| New docs?     | [no]
| Applies to    | [2.3]
| Fixed tickets | []
    @ThomasLandauer @wouterj
    ThomasLandauer authored and wouterj committed Dec 19, 2015
    Configuration menu
    Copy the full SHA
    2b00abe View commit details
    Browse the repository at this point in the history

  12. Revert some changes and fix template names

    @wouterj
    wouterj committed Dec 19, 2015
    Configuration menu
    Copy the full SHA
    99cdc00 View commit details
    Browse the repository at this point in the history