Add Rate limiter #114
Closed
Add Rate limiter #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 96dec40.
Pull Request Test Coverage Report for Build 2152410060
💛 - Coveralls |
ChiTimesChi
reviewed
Apr 13, 2022
| } | ||
|
|
||
| function retryByKappa(bytes32 kappa) external onlyRole(LIMITER_ROLE) { | ||
| (bytes memory toRetry, ) = rateLimited.get(kappa); |
There was a problem hiding this comment.
Check if kappa already exists before calling bridge. I think assumption that all kappas in the queue were not yet processed is too strong to preserve.
if (!IBridge(BRIDGE_ADDRESS).kappaExists(kappa)) {
(bool success, bytes memory returnData) = BRIDGE_ADDRESS.call(toRetry);
require(
success,
Strings.append("could not call bridge:", _getRevertMsg(returnData))
);
}
rateLimited.remove(kappa);
ChiTimesChi
reviewed
Apr 13, 2022
| ); | ||
|
|
||
| for (uint8 i = 0; i < attempts; i++) { | ||
| (bytes32 kappa, bytes memory toRetry, ) = rateLimited.at(i); |
There was a problem hiding this comment.
See comment above:
https://github.com/synapsecns/synapse-contracts/pull/114/files#r849141913
Also, some generalization on retrying the kappas is required.
ChiTimesChi
reviewed
Apr 13, 2022
| ) | ||
| ); | ||
|
|
||
| rateLimited.remove(kappa); |
There was a problem hiding this comment.
Doing map.remove() in the same for loop as map.at() will break things. Either do two separate loops for iteration and deletion. Or even better, change Map to queue and use peek and poll to get the first element and then delete it.
|
Moving to #116 to follow our git flow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
Checklist