Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rate limiter #147

Open
wants to merge 149 commits into
base: master
Choose a base branch
from
Open

Feature/rate limiter #147

wants to merge 149 commits into from

Conversation

trajan0x
Copy link
Contributor

Description

Replaces #114/#116

Checklist

  • New Contracts have been tested
  • Lint has been run
  • I have checked my code and corrected any misspellings

@coveralls
Copy link

coveralls commented May 18, 2022

Pull Request Test Coverage Report for Build 2355528180

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 140 of 263 (53.23%) changed or added relevant lines in 7 files are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+10.6%) to 37.539%

Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/bridge/wrappers/L1BridgeZap.sol 0 1 0.0%
contracts/bridge/libraries/EnumerableQueueUpgradeable.sol 19 25 76.0%
contracts/bridge/wrappers/L2BridgeZap.sol 0 20 0.0%
contracts/bridge/SynapseBridge.sol 58 87 66.67%
contracts/bridge/RateLimiter.sol 58 91 63.74%
contracts/bridge/wrappers/FraxWrapper.sol 0 34 0.0%
Files with Coverage Reduction New Missed Lines %
contracts/bridge/wrappers/L2BridgeZap.sol 8 0.0%
Totals Coverage Status
Change from base Build 2354122152: 10.6%
Covered Lines: 813
Relevant Lines: 2045

💛 - Coveralls

.gitignore Outdated Show resolved Hide resolved

/*** RETRY FUNCTIONS ***/

function retryByKappa(bytes32 kappa) external {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldnt this be nonReentrant?

) internal {
swapMap[_token] = _swap;

uint8 i;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to save gas

Suggested change
uint8 i;
uint256 i;

@trajan0x trajan0x marked this pull request as ready for review May 20, 2022 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants