-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/rate limiter #147
base: master
Are you sure you want to change the base?
Feature/rate limiter #147
Conversation
This reverts commit 96dec40.
Rate limiter final blow
This reverts commit 5a05e15.
* RateLimiter: view functions + their test coverage * fix doc generation * update rate limiter test Co-authored-by: Trajan0x <trajan0x@users.noreply.github.com>
Pull Request Test Coverage Report for Build 2355528180Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
contracts/bridge/RateLimiter.sol
Outdated
|
||
/*** RETRY FUNCTIONS ***/ | ||
|
||
function retryByKappa(bytes32 kappa) external { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldnt this be nonReentrant
?
) internal { | ||
swapMap[_token] = _swap; | ||
|
||
uint8 i; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to save gas
uint8 i; | |
uint256 i; |
Co-authored-by: Blaze <blaze@dorime.org>
Description
Replaces #114/#116
Checklist