Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update prometheus/common/expfmt to pass tests on go1.11 #5311

Closed
Ambrevar opened this issue Nov 6, 2018 · 0 comments
Closed

Update prometheus/common/expfmt to pass tests on go1.11 #5311

Ambrevar opened this issue Nov 6, 2018 · 0 comments
Labels
build Issues caused by or requiring changes to the build system (scripts or Docker image) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Milestone
v1.1.0

Comments

@Ambrevar
Copy link

Ambrevar commented Nov 6, 2018

Expfmt's tests don't pass with go1.11 on syncthing vendored version.

See prometheus/common@c7de230.

Time for an update?
@calmh calmh added the build Issues caused by or requiring changes to the build system (scripts or Docker image) label Nov 6, 2018
imsodin added a commit to imsodin/syncthing that referenced this issue Jan 28, 2019
@imsodin
mod: Update dependencies and tidy (fixes syncthing#5311)
17dbf3a
@calmh calmh closed this as completed in 8815ef9 Jan 28, 2019
calmh added a commit to calmh/syncthing that referenced this issue Feb 2, 2019
@calmh
Merge branch 'master' into largeb
7f08b88 
* master: (61 commits)
  build: Remove outdated&non-functional setup command (fixes syncthing#5454) (syncthing#5455)
  cmd/syncthing, lib/config: Update default config creation (syncthing#5492)
  golangci: Add config file
  cmd/syncthing: Correct strings.HasPrefix args order (syncthing#5498)
  all: Revert the underscore sillyness
  all: A few more interesting linter fixes (syncthing#5502)
  all: Even more boring linter fixes (syncthing#5501)
  all: Bunch of more linter fixes (syncthing#5500)
  all: Fix some linter errors (syncthing#5499)
  lib/db: Fix race in NamespacedKV (syncthing#5496)
  docker: Build outside GOPATH (fixes syncthing#5495)
  cmd/syncthing: Pass SIGTERM on in monitor (fixes syncthing#5493) (syncthing#5494)
  lib/model: In tests disable watching for changes by default (fixes syncthing#5246) (syncthing#5485)
  gui, man, authors: Update docs, translations, and contributors
  test, lib/rc: Integration test fixes and polish (syncthing#5488)
  mod: Update dependencies and tidy (fixes syncthing#5311) (syncthing#5486)
  lib/config: Add omitempty to DeprecatedMinHomeDiskFreePct (fixes syncthing#5482) (syncthing#5484)
  all: Copy owner/group from parent (fixes syncthing#5445) (syncthing#5479)
  vendor: rm -rf vendor (syncthing#5478)
  lib/model: Improve errors while pulling (syncthing#5474)
  ...
calmh added a commit to calmh/syncthing that referenced this issue Feb 2, 2019
@calmh
Merge branch 'master' into ldap3
387f20b 
* master: (62 commits)
  cmd/syncthing: Fixup previous commit
  build: Remove outdated&non-functional setup command (fixes syncthing#5454) (syncthing#5455)
  cmd/syncthing, lib/config: Update default config creation (syncthing#5492)
  golangci: Add config file
  cmd/syncthing: Correct strings.HasPrefix args order (syncthing#5498)
  all: Revert the underscore sillyness
  all: A few more interesting linter fixes (syncthing#5502)
  all: Even more boring linter fixes (syncthing#5501)
  all: Bunch of more linter fixes (syncthing#5500)
  all: Fix some linter errors (syncthing#5499)
  lib/db: Fix race in NamespacedKV (syncthing#5496)
  docker: Build outside GOPATH (fixes syncthing#5495)
  cmd/syncthing: Pass SIGTERM on in monitor (fixes syncthing#5493) (syncthing#5494)
  lib/model: In tests disable watching for changes by default (fixes syncthing#5246) (syncthing#5485)
  gui, man, authors: Update docs, translations, and contributors
  test, lib/rc: Integration test fixes and polish (syncthing#5488)
  mod: Update dependencies and tidy (fixes syncthing#5311) (syncthing#5486)
  lib/config: Add omitempty to DeprecatedMinHomeDiskFreePct (fixes syncthing#5482) (syncthing#5484)
  all: Copy owner/group from parent (fixes syncthing#5445) (syncthing#5479)
  vendor: rm -rf vendor (syncthing#5478)
  ...
@calmh calmh added this to the v1.1.0 milestone Feb 5, 2019
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Jan 29, 2020
@syncthing syncthing locked and limited conversation to collaborators Jan 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
build Issues caused by or requiring changes to the build system (scripts or Docker image) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
3 participants
@calmh @Ambrevar @st-review