Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build.go setup problems with gomodules #5454

Closed
imsodin opened this issue Jan 14, 2019 · 1 comment
Closed

build.go setup problems with gomodules #5454

imsodin opened this issue Jan 14, 2019 · 1 comment
Labels
build Issues caused by or requiring changes to the build system (scripts or Docker image) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Milestone
v1.1.0

Comments

@imsodin
Copy link
Member

imsodin commented Jan 14, 2019

This is not very important, more of a reminder:

gometalinter doesn't support gomodules (alecthomas/gometalinter#569):

[...]
github.com/alecthomas/gometalinter
go: finding github.com/alecthomas/gometalinter v2.0.12+incompatible
go: downloading github.com/alecthomas/gometalinter v2.0.12+incompatible
go: extracting github.com/alecthomas/gometalinter v2.0.12+incompatible
go: finding github.com/google/shlex latest
go: finding gopkg.in/alecthomas/kingpin.v3-unstable latest
go: downloading github.com/google/shlex v0.0.0-20181106134648-c34317bd91bf
go: extracting github.com/google/shlex v0.0.0-20181106134648-c34317bd91bf
go: downloading gopkg.in/alecthomas/kingpin.v3-unstable v3.0.0-20180810215634-df19058c872c
go: extracting gopkg.in/alecthomas/kingpin.v3-unstable v3.0.0-20180810215634-df19058c872c
go: finding github.com/alecthomas/units latest
go: finding github.com/nicksnyder/go-i18n/i18n latest
go: downloading github.com/alecthomas/units v0.0.0-20151022065526-2efee857e7cf
go: extracting github.com/alecthomas/units v0.0.0-20151022065526-2efee857e7cf
go: finding github.com/nicksnyder/go-i18n v1.10.0
go: downloading github.com/nicksnyder/go-i18n v1.10.0
go: extracting github.com/nicksnyder/go-i18n v1.10.0
go: downloading gopkg.in/yaml.v2 v2.0.0-20171116090243-287cf08546ab
go: extracting gopkg.in/yaml.v2 v2.0.0-20171116090243-287cf08546ab
go: finding github.com/pelletier/go-toml v1.2.0
go: downloading github.com/pelletier/go-toml v1.2.0
go: extracting github.com/pelletier/go-toml v1.2.0
# github.com/alecthomas/gometalinter
../../../../pkg/mod/github.com/alecthomas/gometalinter@v2.0.12+incompatible/main.go:36:94: cannot use loadConfig (type func(*kingpin.Application, *kingpin.ParseElement, *kingpin.ParseContext) error) as type kingpin.Action in argument to app.cmdMixin.flagGroup.Flag("config", "Load JSON configuration from file.").Envar("GOMETALINTER_CONFIG").Action
../../../../pkg/mod/github.com/alecthomas/gometalinter@v2.0.12+incompatible/main.go:38:100: cannot use disableAction (type func(*kingpin.Application, *kingpin.ParseElement, *kingpin.ParseContext) error) as type kingpin.Action in argument to app.cmdMixin.flagGroup.Flag("disable", "Disable previously enabled linters.").PlaceHolder("LINTER").Short('D').Action
../../../../pkg/mod/github.com/alecthomas/gometalinter@v2.0.12+incompatible/main.go:39:99: cannot use enableAction (type func(*kingpin.Application, *kingpin.ParseElement, *kingpin.ParseContext) error) as type kingpin.Action in argument to app.cmdMixin.flagGroup.Flag("enable", "Enable previously disabled linters.").PlaceHolder("LINTER").Short('E').Action
../../../../pkg/mod/github.com/alecthomas/gometalinter@v2.0.12+incompatible/main.go:40:83: cannot use cliLinterOverrides (type func(*kingpin.Application, *kingpin.ParseElement, *kingpin.ParseContext) error) as type kingpin.Action in argument to app.cmdMixin.flagGroup.Flag("linter", "Define a linter.").PlaceHolder("NAME:COMMAND:PATTERN").Action
../../../../pkg/mod/github.com/alecthomas/gometalinter@v2.0.12+incompatible/main.go:43:56: cannot use disableAllAction (type func(*kingpin.Application, *kingpin.ParseElement, *kingpin.ParseContext) error) as type kingpin.Action in argument to app.cmdMixin.flagGroup.Flag("disable-all", "Disable all linters.").Action
../../../../pkg/mod/github.com/alecthomas/gometalinter@v2.0.12+incompatible/main.go:44:54: cannot use enableAllAction (type func(*kingpin.Application, *kingpin.ParseElement, *kingpin.ParseContext) error) as type kingpin.Action in argument to app.cmdMixin.flagGroup.Flag("enable-all", "Enable all linters.").Action
../../../../pkg/mod/github.com/alecthomas/gometalinter@v2.0.12+incompatible/main.go:200:12: cannot use loadDefaultConfig (type func(*kingpin.Application, *kingpin.ParseElement, *kingpin.ParseContext) error) as type kingpin.Action in argument to app.Action
exit status 2
exit status 1

and doesn't intend to: alecthomas/gometalinter#518:

Closing this because that is no longer a supported installation mechanism. Use curl https://git.io/vp6lP | sh or download releases directly.

Also "github.com/opennota/check/cmd/..." fails due to golang/go#27215 - a simple workaround exists.

In addition running go run build.go setup updates go.mod/go.sum, which as far as I understand isn't desired.
@imsodin imsodin added the build Issues caused by or requiring changes to the build system (scripts or Docker image) label Jan 14, 2019
@calmh
Copy link
Member

calmh commented Jan 14, 2019

I don't think anyone's run this for years :)

imsodin added a commit to imsodin/syncthing that referenced this issue Jan 14, 2019
@imsodin
build: Remove outdated&non-functional setup command (fixes syncthing#…
c77dea9 
…5454)
imsodin added a commit to imsodin/syncthing that referenced this issue Jan 14, 2019
@imsodin
build: Remove outdated&non-functional setup command (fixes syncthing#…
de4df1c 
…5454)
@calmh calmh closed this as completed in 41d037d Feb 2, 2019
calmh added a commit to calmh/syncthing that referenced this issue Feb 2, 2019
@calmh
Merge branch 'master' into largeb
7f08b88 
* master: (61 commits)
  build: Remove outdated&non-functional setup command (fixes syncthing#5454) (syncthing#5455)
  cmd/syncthing, lib/config: Update default config creation (syncthing#5492)
  golangci: Add config file
  cmd/syncthing: Correct strings.HasPrefix args order (syncthing#5498)
  all: Revert the underscore sillyness
  all: A few more interesting linter fixes (syncthing#5502)
  all: Even more boring linter fixes (syncthing#5501)
  all: Bunch of more linter fixes (syncthing#5500)
  all: Fix some linter errors (syncthing#5499)
  lib/db: Fix race in NamespacedKV (syncthing#5496)
  docker: Build outside GOPATH (fixes syncthing#5495)
  cmd/syncthing: Pass SIGTERM on in monitor (fixes syncthing#5493) (syncthing#5494)
  lib/model: In tests disable watching for changes by default (fixes syncthing#5246) (syncthing#5485)
  gui, man, authors: Update docs, translations, and contributors
  test, lib/rc: Integration test fixes and polish (syncthing#5488)
  mod: Update dependencies and tidy (fixes syncthing#5311) (syncthing#5486)
  lib/config: Add omitempty to DeprecatedMinHomeDiskFreePct (fixes syncthing#5482) (syncthing#5484)
  all: Copy owner/group from parent (fixes syncthing#5445) (syncthing#5479)
  vendor: rm -rf vendor (syncthing#5478)
  lib/model: Improve errors while pulling (syncthing#5474)
  ...
calmh added a commit to calmh/syncthing that referenced this issue Feb 2, 2019
@calmh
Merge branch 'master' into ldap3
387f20b 
* master: (62 commits)
  cmd/syncthing: Fixup previous commit
  build: Remove outdated&non-functional setup command (fixes syncthing#5454) (syncthing#5455)
  cmd/syncthing, lib/config: Update default config creation (syncthing#5492)
  golangci: Add config file
  cmd/syncthing: Correct strings.HasPrefix args order (syncthing#5498)
  all: Revert the underscore sillyness
  all: A few more interesting linter fixes (syncthing#5502)
  all: Even more boring linter fixes (syncthing#5501)
  all: Bunch of more linter fixes (syncthing#5500)
  all: Fix some linter errors (syncthing#5499)
  lib/db: Fix race in NamespacedKV (syncthing#5496)
  docker: Build outside GOPATH (fixes syncthing#5495)
  cmd/syncthing: Pass SIGTERM on in monitor (fixes syncthing#5493) (syncthing#5494)
  lib/model: In tests disable watching for changes by default (fixes syncthing#5246) (syncthing#5485)
  gui, man, authors: Update docs, translations, and contributors
  test, lib/rc: Integration test fixes and polish (syncthing#5488)
  mod: Update dependencies and tidy (fixes syncthing#5311) (syncthing#5486)
  lib/config: Add omitempty to DeprecatedMinHomeDiskFreePct (fixes syncthing#5482) (syncthing#5484)
  all: Copy owner/group from parent (fixes syncthing#5445) (syncthing#5479)
  vendor: rm -rf vendor (syncthing#5478)
  ...
@calmh calmh added this to the v1.1.0 milestone Feb 5, 2019
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Feb 3, 2020
@syncthing syncthing locked and limited conversation to collaborators Feb 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
build Issues caused by or requiring changes to the build system (scripts or Docker image) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
3 participants
@calmh @imsodin @st-review