fix(settings): Fixes Change Pin Setting #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enforces pin attempt counter for the "Change Pin" setting. Closes #1630
|
You have a failing e2e test @coreyphillips |
Updates security.e2e.js.
Updates security.e2e.js.
limpbrains
requested changes
Apr 22, 2024
Resolved as of this commit. |
limpbrains
approved these changes
Apr 22, 2024
pwltr
approved these changes
Apr 22, 2024
|
@coreyphillips This fixes the problem. Although, the user must now enter their PIN to unlock the option to enter their existing PIN to change their PIN. That's 4 PIN entries now, it was 3. Would it be possible to add the countdown to the existing PIN entry to avoid the extra step? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked Issues/Tasks
Type of change
Tests
QA Notes
Forwards user to Auth screen when attempting to Change Pin in order to enforce the pin counter.