Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(settings): Fixes Change Pin Setting #1631

Merged
merged 4 commits into from
Apr 22, 2024
Merged

fix(settings): Fixes Change Pin Setting #1631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f04eaa6
fix(settings): Fixes Change Pin Setting
coreyphillips Apr 11, 2024
4f82777
fix(settings): Update Security Settings Tests
coreyphillips Apr 19, 2024
9af4b93
fix(settings): Update Security Settings Tests
coreyphillips Apr 19, 2024
2105f50
fix(settings): Updates navigation from ChangePin2 to ChangePin
coreyphillips Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions e2e/security.e2e.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,8 @@ d('Settings Security And Privacy', () => {
await device.matchFace();
await sleep(1000);
await element(by.id('ChangePIN')).tap();
await element(by.id('N1').withAncestor(by.id('PinPad'))).multiTap(4);
await sleep(1000);
await element(by.id('N1').withAncestor(by.id('ChangePIN'))).multiTap(4);
await sleep(1000);
await element(by.id('N2').withAncestor(by.id('ChangePIN2'))).multiTap(4);
Expand Down
7 changes: 6 additions & 1 deletion src/screens/Settings/Security/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,12 @@ const SecuritySettings = ({
hide: !pin,
testID: 'ChangePIN',
onPress: (): void => {
navigation.navigate('ChangePin');
navigation.navigate('AuthCheck', {
onSuccess: () => {
navigation.pop();
navigation.navigate('ChangePin');
},
});
},
},
{
Expand Down
Loading