Skip to content

Commit

Permalink
[admission-controller] Don't let istio to instrument the webhook (#222)
Browse files Browse the repository at this point in the history
* fix: Don't let istio to instrument the webhook

Istio and the api-sever does not play pretty well together, like pizza
and pineapple:

* istio/istio#8696
* istio/istio#12187

Chart is open enough for the users to set the podAnnotation with the
api-server instead of not deploying the sidecar in the webhook, but by
default we offer an option that works on most possible scenarios.

* chore: Bump version
  • Loading branch information
Néstor Salceda committed Aug 27, 2021
1 parent 561f3a3 commit 25b4532
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion charts/admission-controller/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: admission-controller
description: Sysdig Admission Controller using Sysdig Secure inline image scanner
type: application
version: 0.4.21
version: 0.4.22
appVersion: 3.5.2
home: https://sysdiglabs.github.io/admission-controller/
icon: https://478h5m1yrfsa3bbe262u7muv-wpengine.netdna-ssl.com/wp-content/uploads/2019/02/Shovel_600px.png
Expand Down
1 change: 1 addition & 0 deletions charts/admission-controller/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ webhook:
prometheus.io/path: "/metrics"
prometheus.io/port: "5000"
prometheus.io/scheme: "https"
sidecar.istio.io/inject: "false"

podSecurityContext: {}

Expand Down

0 comments on commit 25b4532

Please sign in to comment.