[admission-controller] Don't let istio to instrument the webhook #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 27, 2021 18:16
Istio and the api-sever does not play pretty well together, like pizza and pineapple: * istio/istio#8696 * istio/istio#12187 Chart is open enough for the users to set the podAnnotation with the api-server instead of not deploying the sidecar in the webhook, but by default we offer an option that works on most possible scenarios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Istio and the api-server does not play pretty well together, like pizza
and pineapple:
Chart is open enough for the users to set the podAnnotation with the
api-server instead of not deploying the sidecar in the webhook, but by
default we offer an option that works on most possible scenarios.
What this PR does / why we need it:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[mychartname])