wp_die() doesn't end script anymore

[Screenfeed]

Hello,

Sorry to bring bad news. Unless I'm missing something, it seems that something went wrong with #201.

/**
 * @phpstan-return never
 */
function foo() {
	wp_die();
}

This ends with the following message:

Function foo() should always throw an exception or terminate script execution but doesn't do that.

Versions used:

php-stubs/wordpress-stubs v6.3.2
szepeviktor/phpstan-wordpress v1.3.1

[szepeviktor]

@IanDelMar Please hotfix this 🔥

[szepeviktor]

Seems like @return never is does not mean termination.

[szepeviktor]

@IanDelMar Wait! wp_die got no @return never in #110!

[johnbillion]

Looks like a test is needed for assertType('*NEVER*', wp_die('')); too (no second parameter).

[IanDelMar]

Was at work. Will have a look at it now.

[IanDelMar]

I added tests for wp_die() and wp_die(''). Both tests pass, because the extension returns "never" if the number of arguments is less than 3:

phpstan-wordpress/src/WpDieDynamicFunctionReturnTypeExtension.php

Lines 31 to 34 in 78db560

	// Called without $args parameter
	if (count($args) < 3) {
	return new NeverType();
	}

[szepeviktor]

Okay.
What could make the above code snippet fail?

[szepeviktor]

@Screenfeed What is you phpstan-wordpress and wp-stubs version?

[Screenfeed]

@szepeviktor Sorry I should have mentioned that in the OP.

php-stubs/wordpress-stubs v6.3.2
szepeviktor/phpstan-wordpress v1.3.1

[IanDelMar]

Does PHPStan know about the dynamic return type of a function when that function is called by another function?

[szepeviktor]

Does PHPStan know about the dynamic return type of a function when that function is called by another function?

Yes.

[szepeviktor]

\PHPStan\dumpType(wp_die()); says NEVER.

@IanDelMar Adding back wp_die to earlyTerminatingFunctionCalls resolves the problem.
#203 (comment)

[szepeviktor]

@ondrejmirtes Could you help us?
Is there a programmatic way to mark a function early terminating?
wp_die sometimes exits, other times not.

[IanDelMar]

Look at this:

/**
 * @phpstan-return never
 */
function foo() {
	\PHPStan\dumpType(wp_die());
	wp_die();
}
\PHPStan\dumpType(foo());

:51    Dumped type: *NEVER*
:52    Function foo() should always throw an exception or terminate script execution but doesn't do that.
:54    Dumped type: never

[szepeviktor]

😲

[IanDelMar]

There is a NonAcceptingNeverType, is that the correct type to return in the extension?

[szepeviktor]

Yess please!

[IanDelMar]

I was wondering why it's '*NEVER*' not just 'never', but was not aware that there is another never type (NonAcceptingNeverType) and thought PHPStan will know that '*NEVER*' is 'never'.

[johnbillion]

WordPress will *NEVER* die()

[ondrejmirtes]

Yeah, use new NeverType(true) or new NonAcceptingNeverType(). The NeverType needs to be explicit: https://github.com/phpstan/phpstan-src/blob/485922f5c2734af5af15230250340e6c1cc76451/src/Analyser/NodeScopeResolver.php#L1846-L1848

[szepeviktor]

Thank you.

[szepeviktor]

@Screenfeed This release is for you.
https://github.com/szepeviktor/phpstan-wordpress/releases/tag/v1.3.2

[manooweb]

@Screenfeed This release is for you. https://github.com/szepeviktor/phpstan-wordpress/releases/tag/v1.3.2

Yes! It's ok for us 👍 Thank you so much 😉

[Screenfeed]

@szepeviktor Perfect. Thanks a lot to everyone! ❤️