Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dynamic return type extension for wp_die() #201

Merged
merged 2 commits into from
Oct 14, 2023
Merged

Add dynamic return type extension for wp_die() #201

merged 2 commits into from
Oct 14, 2023

Conversation

IanDelMar
Copy link
Contributor

Fixes #200

szepeviktor
szepeviktor reviewed Oct 14, 2023
View reviewed changes
tests/data/wp_die.php Outdated Show resolved Hide resolved
@IanDelMar @szepeviktor
Update tests for wp_die()
1fee226 
Co-authored-by: Viktor Szépe <viktor@szepe.net>
@szepeviktor
Copy link
Owner

szepeviktor commented Oct 14, 2023 •
edited
Loading

The new stubs caused comment and taxonomy errors?

Locking php-stubs/wordpress-stubs (v6.3.2)

@szepeviktor szepeviktor mentioned this pull request Oct 14, 2023
Merged
@szepeviktor
Copy link
Owner

Thank you.

Hereby I unban you from the Internet 🙃

@szepeviktor szepeviktor merged commit 4ed6cf2 into szepeviktor:master Oct 14, 2023
1 of 2 checks passed
@IanDelMar IanDelMar deleted the wp-die branch October 14, 2023 18:56
@szepeviktor szepeviktor mentioned this pull request Oct 15, 2023
Merged
@Screenfeed Screenfeed mentioned this pull request Oct 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szepeviktor szepeviktor szepeviktor left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wp_die() not exclusively an early terminating function
2 participants
@IanDelMar @szepeviktor