Mock PDFGenerator for testing #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #29 +/- ##
==========================================
+ Coverage 96.65% 97.79% +1.13%
==========================================
Files 7 6 -1
Lines 748 724 -24
==========================================
- Hits 723 708 -15
+ Misses 17 11 -6
+ Partials 8 5 -3
Continue to review full report at Codecov.
|
tagatac
added a commit
that referenced
this pull request
Sep 10, 2024
**What is changing**: Check the OS-level open file limit (and adjust it if necessary) prior to writing PDF files. **Why this change is being made**: There is the potential for wkhtmltopdf to need many open files (see wkhtmltopdf/wkhtmltopdf#3081). This was fixed in #14, where it depended on the order of events: 1. Stage the PDF file, getting the number of images 2. Check and adjust the open file limit 3. Flush the PDF file to disk Number 3 was achieved via the call `defer outFile.Close()`: https://github.com/tagatac/bagoup/blob/86f9b32870d2127f3fd3e196cecfc24265cf8d87/write.go#L29 However, #29 removed `Close()` from the `OutFile` interface, collapsing `Stage()` and `Flush()` into a single function `Flush()` run prior to checking and adjusting the open file limit. **Related issue(s)**: Fixes #63 **Follow-up changes needed**: None AFAIK **Is the change completely covered by unit tests? If not, why not?**: Yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26
Also renders #18 invalid as we are now only concerned with the inputs to wkhtmltopdf, and not its behavior.