Increase the open file limit before writing PDFs #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changing: Check the OS-level open file limit (and adjust it if necessary) prior to writing PDF files.
Why this change is being made: There is the potential for wkhtmltopdf to need many open files (see wkhtmltopdf/wkhtmltopdf#3081). This was fixed in #14, where it depended on the order of events:
Number 3 was achieved via the call
defer outFile.Close()
:bagoup/write.go
Line 29 in 86f9b32
However, #29 removed
Close()
from theOutFile
interface, collapsingStage()
andFlush()
into a single functionFlush()
run prior to checking and adjusting the open file limit.Related issue(s): Fixes #63
Follow-up changes needed: None AFAIK
Is the change completely covered by unit tests? If not, why not?: Yes