[LLVM] Add missing pre-processor macro when LLVM is disabled #3702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for jovial-fermat-aa59dc canceled. 🔨 Explore the source changes: 70d765b 🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61aad5662b22b40007606319 |
|
@AmesingFlank Thanks to your feedback, I just pushed the changes related to the other PR I closed to this one as they are all related to LLVM. |
AmesingFlank
reviewed
Dec 4, 2021
taichi/backends/device.cpp
Outdated
| if (dynamic_cast<vulkan::VulkanDevice *>(dst.device) && | ||
| dynamic_cast<cpu::CpuDevice *>(src.device)) { | ||
| // TODO: support direct copy if dst itself supports host write. | ||
| return Device::MemcpyCapability::RequiresStagingBuffer; | ||
| } | ||
| #if TI_WITH_CUDA | ||
| #elif TI_WITH_CUDA |
There was a problem hiding this comment.
Suggested change
| #elif TI_WITH_CUDA | |
| #if TI_WITH_CUDA |
There was a problem hiding this comment.
this is the reason the tests are failing.
There was a problem hiding this comment.
That makes sense, not sure why I used a #elif, I missed this use case in my testing
Some components were still referencing LLVM with TI_WITH_LLVM set to false triggering a build failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some components were still referencing LLVM with TI_WITH_LLVM set to
false triggering a build failure.
Related issue = #3679