Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPU][Vulkan] Add missing ifdef macros if CPU is disabled #3704

Closed
wants to merge 1 commit into from
Closed

[CPU][Vulkan] Add missing ifdef macros if CPU is disabled #3704

wants to merge 1 commit into from

Conversation

ghuau-innopeak
Copy link
Collaborator

Related issue = #3679

@netlify
Copy link

netlify bot commented Dec 3, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: 796c202

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61aab8cb909b64000716794e

@AmesingFlank
Copy link
Collaborator

hmm, can't we just use TI_WITH_LLVM as guards?

@ghuau-innopeak
Copy link
Collaborator Author

ghuau-innopeak commented Dec 4, 2021

hmm, can't we just use TI_WITH_LLVM as guards?

@AmesingFlank Correct... :) I completely missed that the CPU source code was only added when LLVM was enabled. I will update the changes, the question now is... should I close this PR and push the changes in the other PR related to missing TI_WITH_LLVM? (#3702) Or should I still keep this one with the updated changes?

@AmesingFlank
Copy link
Collaborator

hmm, can't we just use TI_WITH_LLVM as guards?

@AmesingFlank Correct... :) I completely missed that the CPU source code was only added when LLVM was enabled. I will update the changes, the question now is... should I close this PR and push the changes in the other PR related to missing TI_WITH_LLVM? (#3702) Or should I still keep this one with the updated changes?

I think either is fine. Up to u really. I just approved #3702 btw.

@ghuau-innopeak
Copy link
Collaborator Author

Closing, PR merged with #3702 as all the changes are now related to LLVM.

@ghuau-innopeak ghuau-innopeak deleted the ghuau/fix_missing_cpu_macro branch December 14, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants