feat: Support mixed MSRV in --version-range #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This expands on the approach taken in taiki-e#212 bucketing packages into rust-versions to run. If we skipped the MSRV (due to `--version-step`), we automatically inject it. If a package's MSRV isn't within the range, we skip it. Benefits - Relatively simple to implement and to explain - We keep the number of runs to a minimum by walking in lock-step the `--version-step`, independent of what each package' MSRV I did have to specialize `--rust-version` vs `--version-range` to avoid `--rust-version` range users walking more than they needed. To keep the progress total accurate, I shifted the calculating of the total from `determine_package_list` to after we have bucketed everything. To make this feasible, I saved off the how many iterations a package will have without the version range being taken into account. As a byproduct, this fixes a bug in taiki-e#212 where it didn't take the rust-version into account when determining the total. Fixes taiki-e#199
|
@taiki-e CI is passing |
|
Great! Could you add a test case for --version-step? |
|
I also should add a warning when a selected package is skipped due to msrv being higher than the end of the range in case it isn't intentional |
|
CI is passing again with the applied changes |
|
Published in 0.6.6. Thanks again @epage! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands on the approach taken in #212 bucketing packages into
rust-versions to run. If we skipped the MSRV (due to
--version-step),we automatically inject it. If a package's MSRV isn't within the range,
we skip it.
Benefits
--version-step, independent of what each package' MSRVI did have to specialize
--rust-versionvs--version-rangeto avoid--rust-versionrange users walking more than they needed.To keep the progress total accurate, I shifted the calculating of the
total from
determine_package_listto after we have bucketedeverything. To make this feasible, I saved off the how many iterations
a package will have without the version range being taken into account.
As a byproduct, this fixes a bug in #212 where it didn't take the
rust-version into account when determining the total.
Fixes #199