Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support mixed MSRV in --version-range #213

Merged
merged 6 commits into from
Sep 9, 2023
Merged

feat: Support mixed MSRV in --version-range #213

merged 6 commits into from
Sep 9, 2023

Commits on Sep 8, 2023

  1. refactor: Make it easier to expand package run data

    @epage
    epage committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    ce6d33e View commit details
    Browse the repository at this point in the history

  2. refactor: Move construction of PackageRuns lower

    @epage
    epage committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    35632ac View commit details
    Browse the repository at this point in the history

  3. refactor: Decouple progress for package selection

    @epage
    epage committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    c38aee4 View commit details
    Browse the repository at this point in the history

  4. refactor: Specialize counts according to how they're used

    @epage
    epage committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    bc0d1b4 View commit details
    Browse the repository at this point in the history

  5. refactor: When expanding a range, return full versions

    @epage
    epage committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    d5c0ea1 View commit details
    Browse the repository at this point in the history

  6. feat: Support mixed MSRV in --version-range 

    This expands on the approach taken in taiki-e#212 bucketing packages into
rust-versions to run.  If we skipped the MSRV (due to `--version-step`),
we automatically inject it.  If a package's MSRV isn't within the range,
we skip it.

Benefits
- Relatively simple to implement and to explain
- We keep the number of runs to a minimum by walking in lock-step the
  `--version-step`, independent of what each package' MSRV

I did have to specialize `--rust-version` vs `--version-range` to avoid
`--rust-version` range users walking more than they needed.

To keep the progress total accurate, I shifted the calculating of the
total from `determine_package_list` to after we have bucketed
everything.  To make this feasible, I saved off the how many iterations
a package will have without the version range being taken into account.

As a byproduct, this fixes a bug in taiki-e#212 where it didn't take the
rust-version into account when determining the total.

Fixes taiki-e#199
    @epage
    epage committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    4a7d564 View commit details
    Browse the repository at this point in the history