-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write SLP files #55
Merged
Merged
Write SLP files #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #55 +/- ##
==========================================
+ Coverage 94.43% 94.77% +0.34%
==========================================
Files 12 12
Lines 1060 1187 +127
==========================================
+ Hits 1001 1125 +124
- Misses 59 62 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements functionality to save
Labels
to.slp
files compatible with core SLEAP.This implementation aims to create
.slp
files that are nearly* identical to those produced in SLEAP v1.3.1 andFORMAT_ID = 1.2
for compatibility.Eventually, this library will replace all of the IO modules in core SLEAP and will implement more flexible serialization formats (with legacy support).
*Because we don't load all of the same metadata as stored in SLEAP legacy files, we can't save it with byte-level equivalence. This is mostly stuff that doesn't matter or isn't used. Currently this includes:
networkx
graph (order inSkeleton.nodes
andSkeleton.edges
are preserved)Track.spawned_on
attributeCloses: #30
Note that this currently doesn't handle
.pkg.slp
files or saving embedded images just yet, but we'll handle that in the next PR.