-
Notifications
You must be signed in to change notification settings - Fork 247
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
users: use generic destinations for user CM form (#3663)
* use destinations for user CM form * use @storybook/test * support status updates on triple field * disable checkbox when form is disabled * update tests --------- Co-authored-by: Nathaniel Caza <mastercactapus@gmail.com>
- Loading branch information
1 parent
3af1cb2
commit 33ccf5e
Showing
15 changed files
with
879 additions
and
667 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
219 changes: 219 additions & 0 deletions
219
web/src/app/users/UserContactMethodFormDest.stories.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,219 @@ | ||
| import React from 'react' | ||
| import type { Meta, StoryObj } from '@storybook/react' | ||
| import UserContactMethodFormDest, { Value } from './UserContactMethodFormDest' | ||
| import { expect, within, userEvent, waitFor } from '@storybook/test' | ||
| import { handleDefaultConfig } from '../storybook/graphql' | ||
| import { useArgs } from '@storybook/preview-api' | ||
| import { HttpResponse, graphql } from 'msw' | ||
|
|
||
| const meta = { | ||
| title: 'users/UserContactMethodFormDest', | ||
| component: UserContactMethodFormDest, | ||
| tags: ['autodocs'], | ||
| parameters: { | ||
| msw: { | ||
| handlers: [ | ||
| handleDefaultConfig, | ||
| graphql.query('ValidateDestination', ({ variables: vars }) => { | ||
| return HttpResponse.json({ | ||
| data: { | ||
| destinationFieldValidate: vars.input.value === '+15555555555', | ||
| }, | ||
| }) | ||
| }), | ||
| ], | ||
| }, | ||
| }, | ||
| render: function Component(args) { | ||
| const [, setArgs] = useArgs() | ||
| const onChange = (newValue: Value): void => { | ||
| if (args.onChange) args.onChange(newValue) | ||
| setArgs({ value: newValue }) | ||
| } | ||
| return <UserContactMethodFormDest {...args} onChange={onChange} /> | ||
| }, | ||
| } satisfies Meta<typeof UserContactMethodFormDest> | ||
|
|
||
| export default meta | ||
| type Story = StoryObj<typeof meta> | ||
|
|
||
| export const SupportStatusUpdates: Story = { | ||
| args: { | ||
| value: { | ||
| name: 'supports status', | ||
| dest: { | ||
| type: 'supports-status', | ||
| values: [ | ||
| { | ||
| fieldID: 'phone-number', | ||
| value: '+15555555555', | ||
| }, | ||
| ], | ||
| }, | ||
| statusUpdates: false, | ||
| }, | ||
| disabled: false, | ||
| }, | ||
| play: async ({ canvasElement }) => { | ||
| const canvas = within(canvasElement) | ||
| // ensure status updates checkbox is clickable | ||
|
|
||
| await expect( | ||
| await canvas.findByLabelText('Send alert status updates'), | ||
| ).not.toBeDisabled() | ||
| }, | ||
| } | ||
|
|
||
| export const RequiredStatusUpdates: Story = { | ||
| args: { | ||
| value: { | ||
| name: 'required status', | ||
| dest: { | ||
| type: 'required-status', | ||
| values: [ | ||
| { | ||
| fieldID: 'phone-number', | ||
| value: '+15555555555', | ||
| }, | ||
| ], | ||
| }, | ||
| statusUpdates: false, | ||
| }, | ||
| disabled: false, | ||
| }, | ||
| play: async ({ canvasElement }) => { | ||
| const canvas = within(canvasElement) | ||
| // ensure status updates checkbox is not clickable | ||
|
|
||
| await expect( | ||
| await canvas.findByLabelText( | ||
| 'Send alert status updates (cannot be disabled for this type)', | ||
| ), | ||
| ).toBeDisabled() | ||
| }, | ||
| } | ||
|
|
||
| export const ErrorSingleField: Story = { | ||
| args: { | ||
| value: { | ||
| name: '-notvalid', | ||
| dest: { | ||
| type: 'single-field', | ||
| values: [ | ||
| { | ||
| fieldID: 'phone-number', | ||
| value: '+', | ||
| }, | ||
| ], | ||
| }, | ||
| statusUpdates: false, | ||
| }, | ||
| disabled: false, | ||
| errors: [ | ||
| { | ||
| field: 'name', | ||
| message: 'must begin with a letter', | ||
| name: 'FieldError', | ||
| path: [], | ||
| details: {}, | ||
| }, | ||
| ], | ||
| }, | ||
| play: async ({ canvasElement }) => { | ||
| const canvas = within(canvasElement) | ||
| await userEvent.type(await canvas.findByLabelText('Phone Number'), '123') | ||
|
|
||
| // ensure errors are shown | ||
| await expect( | ||
| await canvas.findByText('Must begin with a letter'), | ||
| ).toBeVisible() | ||
| await waitFor(async function CloseIcon() { | ||
| await expect(await canvas.findByTestId('CloseIcon')).toBeVisible() | ||
| }) | ||
| }, | ||
| } | ||
|
|
||
| export const ErrorMultiField: Story = { | ||
| args: { | ||
| value: { | ||
| name: '-notvalid', | ||
| dest: { | ||
| type: 'triple-field', | ||
| values: [ | ||
| { | ||
| fieldID: 'first-field', | ||
| value: '+', | ||
| }, | ||
| { | ||
| fieldID: 'second-field', | ||
| value: 'notAnEmail', | ||
| }, | ||
| { | ||
| fieldID: 'third-field', | ||
| value: '-', | ||
| }, | ||
| ], | ||
| }, | ||
| statusUpdates: false, | ||
| }, | ||
| disabled: false, | ||
| errors: [ | ||
| { | ||
| field: 'name', | ||
| message: 'must begin with a letter', | ||
| name: 'FieldError', | ||
| path: [], | ||
| details: {}, | ||
| }, | ||
| ], | ||
| }, | ||
| play: async ({ canvasElement }) => { | ||
| const canvas = within(canvasElement) | ||
| await userEvent.type(await canvas.findByLabelText('First Item'), '123') | ||
|
|
||
| // ensure errors are shown | ||
| await expect( | ||
| await canvas.findByText('Must begin with a letter'), | ||
| ).toBeVisible() | ||
|
|
||
| await waitFor(async function ThreeCloseIcons() { | ||
| await expect(await canvas.findAllByTestId('CloseIcon')).toHaveLength(3) | ||
| }) | ||
| }, | ||
| } | ||
|
|
||
| export const Disabled: Story = { | ||
| args: { | ||
| value: { | ||
| name: 'disabled dest', | ||
| dest: { | ||
| type: 'triple-field', | ||
| values: [], | ||
| }, | ||
| statusUpdates: false, | ||
| }, | ||
| disabled: true, | ||
| }, | ||
| play: async ({ canvasElement }) => { | ||
| const canvas = within(canvasElement) | ||
|
|
||
| const combo = await canvas.findByRole('combobox') | ||
|
|
||
| // get it's input field sibling (combo is a dom element) | ||
| const input = combo.parentElement?.querySelector('input') | ||
| await expect(input).toBeDisabled() | ||
|
|
||
| await expect( | ||
| await canvas.findByPlaceholderText('11235550123'), | ||
| ).toBeDisabled() | ||
| await expect( | ||
| await canvas.findByPlaceholderText('foobar@example.com'), | ||
| ).toBeDisabled() | ||
| await expect( | ||
| await canvas.findByPlaceholderText('slack user ID'), | ||
| ).toBeDisabled() | ||
| await expect( | ||
| await canvas.findByLabelText('Send alert status updates'), | ||
| ).toBeDisabled() | ||
| }, | ||
| } |
Oops, something went wrong.