Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

users: use generic destinations for user CM form #3663

Merged
merged 5 commits into from
Feb 9, 2024
Merged

Conversation

tony-tvu
Copy link
Collaborator

@tony-tvu tony-tvu commented Feb 7, 2024

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This PR updates the UserContactMethod form to use generic destinations when the experimental flag is set make start EXPERIMENTAL=dest-types.

Which issue(s) this PR fixes:
part of #2639

Out of Scope:
N/A

Screenshots:
1
2

Describe any introduced user-facing changes:
N/A, behavior should be the same as today.

Describe any introduced API changes:
N/A

Additional Info:
N/A

@github-actions github-actions bot added the size/l label Feb 7, 2024
ethan-haynes
ethan-haynes previously approved these changes Feb 7, 2024
mastercactapus
mastercactapus previously approved these changes Feb 7, 2024
allending313
allending313 previously approved these changes Feb 7, 2024
@mastercactapus mastercactapus dismissed stale reviews from allending313, ethan-haynes, and themself via 3b8f067 February 8, 2024 22:39
Copy link
Collaborator

@allending313 allending313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tony-tvu tony-tvu merged commit 33ccf5e into master Feb 9, 2024
7 checks passed
@tony-tvu tony-tvu deleted the user-CM-dest-form branch February 9, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants