test: revert and freeze wasm-pack module
#174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
This is now an upstream issue. |
AaronFeickert
changed the title
wasm-pack modulewasm-pack module
stringhandler
pushed a commit
to tari-project/tari
that referenced
this pull request
Mar 22, 2023
Description --- Reverts and freezes `wasm-pack@0.10.3` due to an apparent upstream issue. Fixes (at least temporarily) [issue 5261](#5261). Motivation and Context --- There's an apparent issue with the `wasm-pack` Node.js module at the 0.11.0 version that breaks CI operations (and which [also affects](tari-project/tari-crypto#174) `tari-crypto`). While an [earlier PR](#5258) disabled this CI, it seems unnecessary and somewhat risky not to have these tests. Reverting to the 0.10.3 version is at least a temporary fix. How Has This Been Tested? --- With the fix, CI should pass. What process can a PR reviewer use to test or verify this change? --- Run the equivalent commands locally, and ensure that CI passes with the change. Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify
SWvheerden
pushed a commit
to tari-project/tari
that referenced
this pull request
Mar 22, 2023
Description --- Reverts and freezes `wasm-pack@0.10.3` due to an apparent upstream issue. Fixes (at least temporarily) [issue 5261](#5261). Motivation and Context --- There's an apparent issue with the `wasm-pack` Node.js module at the 0.11.0 version that breaks CI operations (and which [also affects](tari-project/tari-crypto#174) `tari-crypto`). While an [earlier PR](#5258) disabled this CI, it seems unnecessary and somewhat risky not to have these tests. Reverting to the 0.10.3 version is at least a temporary fix. How Has This Been Tested? --- With the fix, CI should pass. What process can a PR reviewer use to test or verify this change? --- Run the equivalent commands locally, and ensure that CI passes with the change. Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify
SWvheerden
pushed a commit
to tari-project/tari
that referenced
this pull request
Mar 22, 2023
Description --- Reverts and freezes `wasm-pack@0.10.3` due to an apparent upstream issue. Fixes (at least temporarily) [issue 5261](#5261). Motivation and Context --- There's an apparent issue with the `wasm-pack` Node.js module at the 0.11.0 version that breaks CI operations (and which [also affects](tari-project/tari-crypto#174) `tari-crypto`). While an [earlier PR](#5258) disabled this CI, it seems unnecessary and somewhat risky not to have these tests. Reverting to the 0.10.3 version is at least a temporary fix. How Has This Been Tested? --- With the fix, CI should pass. What process can a PR reviewer use to test or verify this change? --- Run the equivalent commands locally, and ensure that CI passes with the change. Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify
AaronFeickert
force-pushed
the
revert-wasm
branch
2 times, most recently
from
b1fd957
to
cdab66c
Compare
AaronFeickert
force-pushed
the
revert-wasm
branch
2 times, most recently
from
d738d7c
to
87bb7c8
Compare
AaronFeickert
force-pushed
the
revert-wasm
branch
from
9475e0f
to
0ca6a00
Compare
|
This now removes the |
stringhandler
approved these changes
Apr 5, 2023
Merged
CjS77
pushed a commit
that referenced
this pull request
May 19, 2023
Previously, an upstream [issue](rustwasm/wasm-pack#1248) with `wasm-pack` resulted in CI failure. Because of this, the dependency was [reverted and frozen](#174) at a working version. A recent `wasm-pack` minor version bump should have this working again. This PR updates and freezes at this version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an issue with WASM builds and tests on the current 0.11.0 version of the
wasm-packNode.js module that isn't present in the 0.10.3 version.Until that issue is fixed upstream, this PR reverts to and freezes at the known working version.