test: revert and freeze wasm-pack module
#5262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is now an upstream issue. |
SWvheerden
approved these changes
Mar 22, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts and freezes
wasm-pack@0.10.3due to an apparent upstream issue.Fixes (at least temporarily) issue 5261.
Motivation and Context
There's an apparent issue with the
wasm-packNode.js module at the 0.11.0 version that breaks CI operations (and which also affectstari-crypto).While an earlier PR disabled this CI, it seems unnecessary and somewhat risky not to have these tests.
Reverting to the 0.10.3 version is at least a temporary fix.
How Has This Been Tested?
With the fix, CI should pass.
What process can a PR reviewer use to test or verify this change?
Run the equivalent commands locally, and ensure that CI passes with the change.
Breaking Changes