Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Windows, allow for customization of the name of the Window Class (current value hard coded is "Window Class") #769

Closed
1 of 2 tasks
geraudloup opened this issue Jul 25, 2023 · 1 comment · Fixed by #770

Comments

@geraudloup
Copy link
Contributor

geraudloup commented Jul 25, 2023

Mirror of issue opened on upstream project winit : rust-windowing/winit#2977

Is your feature request related to a problem? Please describe.
Currently, on Windows, all windows created by Tao have the same class Window Class, it would be neet to allow for customization of the Windows' window class name. One use case: some windows custom hotkey managers leverage window class names to select windows...

Describe the solution you'd like

  • In src\platform\windows.rs add a with_window_classname
  • In src\platform_impl\windows\mod.rs, in PlatformSpecificWindowBuilderAttributes add a window_classname attribute and in impl Default for PlatformSpecificWindowBuilderAttributes add a default value for window_classname of Window Class (non breaking change)

Describe alternatives you've considered
No alternative, unless simply dumping those tools and find one using other characteristics of windows...

Would you want to assign yourself to implement this feature?

  • Yes
  • No
geraudloup added a commit to geraudloup/tao that referenced this issue Jul 25, 2023
(current value hard coded is "Window Class")
geraudloup added a commit to geraudloup/tao that referenced this issue Jul 25, 2023
(current value hard coded is "Window Class")
@geraudloup
Copy link
Contributor Author

geraudloup commented Jul 25, 2023

This issue is mirrored on winit and the feature will be mirrored there for future compatibility : rust-windowing/winit#2977

geraudloup added a commit to geraudloup/tao that referenced this issue Jul 25, 2023
allow to customize it instead of current value hard coded "Window Class"
geraudloup added a commit to geraudloup/tao that referenced this issue Jul 25, 2023
allow to customize it instead of current value hard coded "Window Class"
geraudloup added a commit to geraudloup/tao that referenced this issue Jul 26, 2023
allow to customize it instead of current value hard coded "Window Class"
geraudloup added a commit to geraudloup/tao that referenced this issue Jul 26, 2023
allow to customize it instead of current value hard coded "Window Class"
geraudloup added a commit to geraudloup/tao that referenced this issue Jul 27, 2023
allow to customize it instead of current value hard coded "Window Class"
geraudloup added a commit to geraudloup/tao that referenced this issue Jul 27, 2023
allow to customize it instead of current value hard coded "Window Class"
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant