-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On Windows, allow for customization of the name of the Window Class (current value hard coded is "Window Class") #769
Labels
Comments
2 tasks
geraudloup
added a commit
to geraudloup/tao
that referenced
this issue
Jul 25, 2023
(current value hard coded is "Window Class")
geraudloup
added a commit
to geraudloup/tao
that referenced
this issue
Jul 25, 2023
(current value hard coded is "Window Class")
13 tasks
This issue is mirrored on winit and the feature will be mirrored there for future compatibility : rust-windowing/winit#2977 |
geraudloup
added a commit
to geraudloup/tao
that referenced
this issue
Jul 25, 2023
allow to customize it instead of current value hard coded "Window Class"
geraudloup
added a commit
to geraudloup/tao
that referenced
this issue
Jul 25, 2023
allow to customize it instead of current value hard coded "Window Class"
geraudloup
added a commit
to geraudloup/tao
that referenced
this issue
Jul 26, 2023
allow to customize it instead of current value hard coded "Window Class"
geraudloup
added a commit
to geraudloup/tao
that referenced
this issue
Jul 26, 2023
allow to customize it instead of current value hard coded "Window Class"
13 tasks
geraudloup
added a commit
to geraudloup/tao
that referenced
this issue
Jul 27, 2023
allow to customize it instead of current value hard coded "Window Class"
geraudloup
added a commit
to geraudloup/tao
that referenced
this issue
Jul 27, 2023
allow to customize it instead of current value hard coded "Window Class"
amrbashir
pushed a commit
that referenced
this issue
Jul 28, 2023
Merged
amrbashir
pushed a commit
that referenced
this issue
Aug 15, 2023
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Mirror of issue opened on upstream project winit : rust-windowing/winit#2977
Is your feature request related to a problem? Please describe.
Currently, on Windows, all windows created by Tao have the same class Window Class, it would be neet to allow for customization of the Windows' window class name. One use case: some windows custom hotkey managers leverage window class names to select windows...
Describe the solution you'd like
src\platform\windows.rs
add awith_window_classname
src\platform_impl\windows\mod.rs
, inPlatformSpecificWindowBuilderAttributes
add awindow_classname
attribute and inimpl Default for PlatformSpecificWindowBuilderAttributes
add a default value forwindow_classname
ofWindow Class
(non breaking change)Describe alternatives you've considered
No alternative, unless simply dumping those tools and find one using other characteristics of windows...
Would you want to assign yourself to implement this feature?
The text was updated successfully, but these errors were encountered: