Editorial: avoid using Type macro for simple type tests #2874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelficarra
changed the title
ljharb
reviewed
Aug 30, 2022
bakkot
approved these changes
Aug 31, 2022
There was a problem hiding this comment.
Didn't review for completeness, but what's here LGTM.
I think it would be worth putting something in the "Object Type" section which specifically calls out that some members of the type are callable. The current "is logically a collection of properties" definition really obscures that. Not as part of this PR, though.
michaelficarra
added
the
ready to merge
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Sep 2, 2022
ljharb
pushed a commit
to jmdyck/ecma262
that referenced
this pull request
Sep 2, 2022
anba
added a commit
to anba/ecma402
that referenced
this pull request
Aug 14, 2023
Updated to match <tc39/ecma262#2874>.
ben-allen
pushed a commit
to ben-allen/ecma402
that referenced
this pull request
May 24, 2024
Updated to match <tc39/ecma262#2874>.
ben-allen
pushed a commit
to ben-allen/ecma402
that referenced
this pull request
May 24, 2024
Updated to match <tc39/ecma262#2874>.
ben-allen
pushed a commit
to tc39/ecma402
that referenced
this pull request
May 24, 2024
Updated to match <tc39/ecma262#2874>.
ben-allen
pushed a commit
to tc39/ecma402
that referenced
this pull request
May 24, 2024
Updated to match <tc39/ecma262#2874>.
domenic
pushed a commit
to whatwg/html
that referenced
this pull request
Oct 28, 2024
dizhang168
pushed a commit
to dizhang168/html
that referenced
this pull request
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial resolution for #2870, as suggested by @jmdyck.