Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: remove Type() AO #3420

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Editorial: remove Type() AO #3420

wants to merge 2 commits into from

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Sep 6, 2024

Closes #3339.

spec.html Outdated Show resolved Hide resolved
ljharb added a commit to ljharb/ecma262 that referenced this pull request Sep 6, 2024
ljharb added a commit to ljharb/ecma262 that referenced this pull request Sep 6, 2024
spec.html Outdated Show resolved Hide resolved
Copy link
Member

@michaelficarra michaelficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ljharb added a commit to ljharb/ecma262 that referenced this pull request Sep 6, 2024
ljharb added a commit to ljharb/ecma262 that referenced this pull request Sep 6, 2024
ljharb added a commit to ljharb/ecma262 that referenced this pull request Sep 6, 2024
ljharb added a commit to ljharb/ecma262 that referenced this pull request Sep 6, 2024
ljharb added a commit to ljharb/ecma262 that referenced this pull request Sep 6, 2024
@ljharb ljharb added the editor call to be discussed in the next editor call label Sep 10, 2024
Copy link
Contributor

@syg syg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % oldid comment

@@ -1118,10 +1118,9 @@ <h1>Identity</h1>
</emu-clause>
</emu-clause>

<emu-clause id="sec-ecmascript-data-types-and-values" aoid="Type">
<emu-clause id="sec-ecmascript-data-types-and-values">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have an oldid somewhere, maybe on SameType, as a hint to readers for the new style.

@michaelficarra michaelficarra removed the editor call to be discussed in the next editor call label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants