Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CreateDateTimeFormat: "matcher" instead of "formatMatcher" passed to AdjustDateTimeStyleFormat #3059

Closed
anba opened this issue Dec 9, 2024 · 0 comments
Closed

CreateDateTimeFormat: "matcher" instead of "formatMatcher" passed to AdjustDateTimeStyleFormat #3059

anba opened this issue Dec 9, 2024 · 0 comments
Assignees
@ptomato
Labels
editorial spec-text Specification text involved

Comments

@anba
Copy link
Contributor

anba commented Dec 9, 2024

All calls to AdjustDateTimeStyleFormat incorrectly pass matcher. It should instead be formatMatcher.
@ptomato ptomato self-assigned this Dec 10, 2024
@ptomato ptomato added spec-text Specification text involved editorial labels Dec 10, 2024
ptomato added a commit that referenced this issue Dec 11, 2024
@ptomato
Editorial: Fix wrong variable in CreateDateTimeFormat
b1216b2 
"matcher" is the locale matcher here, not the format matcher. We need to
pass "formatMatcher"; otherwise this breaks a type assertion in
AdjustDateTimeStyleFormat.

h/t Anba

Closes: #3059
@ptomato ptomato mentioned this issue Dec 11, 2024
Merged
@Ms2ger Ms2ger closed this as completed in 8acd353 Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptomato ptomato

Labels
editorial spec-text Specification text involved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ptomato @anba