Editorial: Next batch of minor editorial issues #3060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not in fact a string, but code points. We need to pass it through CodePointsToString before giving it to ParseDateTimeUTCOffset. h/t Anba Closes: #3056
This removes some steps that can throw and therefore look observable, but they were effectively dead code; the value stored in the [[TimeZone]] internal slot is guaranteed to be a valid available time zone identifier. h/t Anba Closes: #3057
"matcher" is the locale matcher here, not the format matcher. We need to pass "formatMatcher"; otherwise this breaks a type assertion in AdjustDateTimeStyleFormat. h/t Anba Closes: #3059
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3060 +/- ##
=======================================
Coverage 95.73% 95.74%
=======================================
Files 21 21
Lines 9716 9712 -4
Branches 1742 1741 -1
=======================================
- Hits 9302 9299 -3
+ Misses 363 362 -1
Partials 51 51 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3056, #3057, #3059