Normative: Remove duplicates in PrepareTemporalFields #2570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
May 3, 2023
Codecov Report
@@ Coverage Diff @@
## main #2570 +/- ##
==========================================
+ Coverage 95.98% 96.15% +0.17%
==========================================
Files 20 20
Lines 11574 11275 -299
Branches 2201 2159 -42
==========================================
- Hits 11109 10842 -267
+ Misses 401 369 -32
Partials 64 64
|
|
This change achieved consensus in the May 2023 TC39 plenary meeting, including the latest revisions. We'll need to pull in test262 tests before merging it. |
ptomato
approved these changes
May 17, 2023
guijemont
added a commit
to guijemont/test262
that referenced
this pull request
Jun 20, 2023
It should be an error to return duplicate fields in a Calendar's field() method, thus we throw if we encounter one in PrepareTemporalFields. There are two cases (PlainMonthDay.prototype.toPlainDate and PlainYearMonth.prototype.toPlainDate) where, after checking on the return values of field() in previous invocations of PrepareTemporalFields, we want to deduplicate the field name list in a later call to PrepareTemporalFields after concatenating them, since we sort them in PrepareTemporalFields. For this reason, we add a duplicateBehavior parameter to PrepareTemporalFields. This allows us to remove the MergeLists abstract operation, now replaced by a simple list concatenation and deduplication in PrepareTemporalFields with duplicateBehavior set to ignore. It should also be an error to return field names 'constructor' or '__proto__' in a Calendar's field() method, and we throw if that happens. Fixes tc39#2532, 2576.
ptomato
pushed a commit
to guijemont/test262
that referenced
this pull request
Jul 17, 2023
ptomato
pushed a commit
to tc39/test262
that referenced
this pull request
Jul 17, 2023
* Add tests for the new PrepareTemporalFields behavior for all direct callers See tc39/proposal-temporal#2570 * Add tests for the new PrepareTemporalFields behavior for indirect callers through ToTemporalDate * Add tests for the new PrepareTemporalFields behavior for indirect callers through ToTemporalDateTime * Add tests for the new PrepareTemporalFields behavior for indirect callers through ToTemporalZonedDateTime * Add tests for the new PrepareTemporalFields behavior for indirect callers through ToTemporalYearMonth * Add tests for the new PrepareTemporalFields behavior for indirect callers through ToTemporalMonthDay * Add tests for the new PrepareTemporalFields behavior for indirect callers through ToRelativeTemporalObject * Add tests for the new PrepareTemporalFields behavior for indirect callers through AddDurationToOrSubtractDurationFromPlainYearMonth
|
Tests are in. |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Sep 13, 2023
…=allstarschh Implement the changes from <tc39/proposal-temporal#2570>. Differential Revision: https://phabricator.services.mozilla.com/D185408
vinnydiehl
pushed a commit
to vinnydiehl/mozilla-unified
that referenced
this pull request
Sep 14, 2023
…=allstarschh Implement the changes from <tc39/proposal-temporal#2570>. Differential Revision: https://phabricator.services.mozilla.com/D185408
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2532.
In some cases, duplicate property names are possible in PrepareTemporalFields(). Remove duplicates there, which removes the need for MergeLists(), which is replaced by a list-concatenation in the two places where it was used.
Updates PrepareTemporalFields() to remove duplicates, and {PlainYearMonth,PlainMonthDay}.prototype.toPlainDate() to use list-concatenation instead of MergeLists().
Removes MergeLists() as it's not used any more.
Updates polyfill to match the changes.