Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporal Issue 2532 #3858

Merged
merged 8 commits into from
Jul 17, 2023
Merged

Temporal Issue 2532 #3858

merged 8 commits into from
Jul 17, 2023

Conversation

guijemont
Copy link
Contributor

Add tests for the new PrepareTemporalFields behavior, that has some observable changes where many functions throw when encountering a calendar the fields() method of which returns duplicates, certain values that create duplicates internally, __proto__ or constructor.

See tc39/proposal-temporal#1315

@guijemont guijemont requested a review from a team as a code owner June 20, 2023 15:57
@guijemont
Copy link
Contributor Author

I've left the changes in many individual commits in the hope that it makes review easier, but it probably makes more sense to land this as one commit.

@ptomato ptomato changed the title Issue 2532 Temporal Issue 2532 Jun 20, 2023
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed a representative sample of this, but it looks good.

@ptomato ptomato merged commit 016e4bf into tc39:main Jul 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants