Normative: Change overflow behaviour of PYM/PMD.toPlainDate #2718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomato
added
spec-text
This was referenced Nov 3, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2718 +/- ##
=======================================
Coverage 96.38% 96.38%
=======================================
Files 21 21
Lines 12444 12444
Branches 2250 2250
=======================================
Hits 11994 11994
Misses 395 395
Partials 55 55 ☔ View full report in Codecov by Sentry. |
justingrant
approved these changes
Nov 3, 2023
ptomato
force-pushed
the
2706-toplaindate-overflow
branch
from
bb1af83
to
1d7b724
Compare
|
Tests are in tc39/test262#3954. |
jasonwilliams
approved these changes
Nov 20, 2023
This changes PlainMonthDay.p.toPlainDate and PlainYearMonth.p.toPlainDate
to constrain nonexistent resulting dates instead of throwing.
For example,
birthdaysThisYear = listOfBirthdays.map((pmd) =>
pmd.toPlainDate({ year: 2023 })
The above should not throw if one of the birthdays is February 29th. That
would go against Temporal's design principle of avoiding data-driven
exceptions.
(If you still want the throwing behaviour, you can get it using the more
verbose way, see below.)
Temporal.PlainDate.from({
year: 2023, monthCode: pmd.monthCode, pmd.day
}, { overflow: 'reject' })
Closes: #2706
ptomato
force-pushed
the
2706-toplaindate-overflow
branch
from
1d7b724
to
724dfb6
Compare
|
This change got consensus at the November 2023 TC39 meeting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes PlainMonthDay.p.toPlainDate and PlainYearMonth.p.toPlainDate to constrain nonexistent resulting dates instead of throwing.
For example,
The above should not throw if one of the birthdays is February 29th. That would go against Temporal's design principle of avoiding data-driven exceptions.
(If you still want the throwing behaviour, you can get it using the more verbose way, see below.)
Closes: #2706