Post-adjustment: Remove unnecessary object creation #2806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @anba |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2806 +/- ##
==========================================
+ Coverage 96.46% 96.59% +0.13%
==========================================
Files 23 23
Lines 12310 12284 -26
Branches 2271 2272 +1
==========================================
- Hits 11875 11866 -9
+ Misses 374 356 -18
- Partials 61 62 +1 ☔ View full report in Codecov by Sentry. |
Ms2ger
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address belated feedback from Anba on #2718. The options object previously created here is unnecessary, because 'constrain' is always the default for this option. Not creating the options object here is consistent with the rest of the spec text.
Closes: #2803