Implementation of RFC: Async Helpers (#3724) #3728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Nov 24, 2022
Merged
cjtenny
force-pushed
the
rfc-async-helpers-impl
branch
2 times, most recently
from
0b19ce3
to
e776c25
Compare
Merged
ptomato
requested changes
Jan 20, 2023
test/harness/asyncHelpers-throwsAsync-funcOrThenable-throws-sync.js
Outdated
Show resolved
Hide resolved
test/harness/asyncHelpers-throwsAsync-invalid-funcOrThenable.js
Outdated
Show resolved
Hide resolved
...ge/statements/class/decorator/syntax/valid/decorator-call-expr-identifier-reference-yield.js
Outdated
Show resolved
Hide resolved
cjtenny
force-pushed
the
rfc-async-helpers-impl
branch
from
e776c25
to
325167d
Compare
|
Rebased and addressed feedback; feedback addressed in separate commit, nothing else changed in older commits. I'm sorry I dropped the ball on this and hadn't responded sooner. |
ptomato
approved these changes
Feb 13, 2023
…ync, per rfcs/async-helpers.md
…d instead of a Promise
…DONE); to use asyncTest
Co-authored-by: Philip Chimento <philip.chimento@gmail.com>
ptomato
force-pushed
the
rfc-async-helpers-impl
branch
from
4d5391c
to
b5e7e09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the
harness/asyncHelpers.jsfile proposed in @ptomato 's RFC, with its functionsasyncTest(testFunc)andassert.throwsAsync(expectedErrorConstructor, funcOrThenable, message). Also included are tests for both, including tests mirroringassert.throwsand a number of additional throwsAsync-specific tests.Per @jugglinmike 's comments in the maintainers call, never uses await; always explicitly invokes as a thenable.
Implements the original intention of accepting a function or thenable for throwsAsync, happy to modify if there's some general agreement on changing that.