Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for the asyncItems argument to Array.fromAsync. #3754

Merged
merged 9 commits into from
Mar 10, 2023
Merged

Add tests for the asyncItems argument to Array.fromAsync. #3754

merged 9 commits into from
Mar 10, 2023

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Dec 20, 2022

Depends on #3724 (RFC) and #3728.

@Ms2ger Ms2ger requested a review from a team as a code owner December 20, 2022 14:22
ptomato
ptomato reviewed Feb 23, 2023
View reviewed changes
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

test/built-ins/Array/fromAsync/asyncitems-arraylike-promise.js Outdated Show resolved Hide resolved
test/built-ins/Array/fromAsync/asyncitems-asynciterator-sync.js Outdated Show resolved Hide resolved
test/built-ins/Array/fromAsync/asyncitems-function.js Outdated Show resolved Hide resolved
test/built-ins/Array/fromAsync/asyncitems-iterator-async.js Outdated Show resolved Hide resolved
test/built-ins/Array/fromAsync/asyncitems-bigint.js Show resolved Hide resolved
test/built-ins/Array/fromAsync/asyncitems-null-undefined.js Show resolved Hide resolved
@ptomato ptomato mentioned this pull request Feb 23, 2023
Closed
70 tasks
Ms2ger
Ms2ger commented Mar 7, 2023
View reviewed changes
Copy link
Contributor Author

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will review your other comments later

test/built-ins/Array/fromAsync/asyncitems-null-undefined.js Show resolved Hide resolved
ptomato
ptomato approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Optionally, consider adding a comment like // See explanation in asyncitems-array-add-to-empty.js to the other tests that rely on the first next() call having happened by the time we await the promise, like in asyncitems-array-add-to-singleton.js?

@Ms2ger Ms2ger merged commit 9704d7f into main Mar 10, 2023
@Ms2ger Ms2ger deleted the Array.fromAsync branch March 10, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptomato ptomato ptomato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ms2ger @ptomato