Improvements to Temporal tests #3819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ptomato
commented
Apr 22, 2023
ptomato
commented
- Fix a leftover from debugging
- Improve comments and assertion messages
- Improve printing of property names in observer helpers
- Improve coverage of order-of-operations tests in preparation for Normative: Audit of user-visible operations in Temporal proposal-temporal#2519
I had been using slice() here to cut down the list of operations to compare during debugging, but accidentally left it in.
Add order-of-operations tests for: - Temporal.ZonedDateTime.p.getISOFields() - Temporal.ZonedDateTime.p.round() - years with ZonedDateTime relativeTo in Temporal.Duration.p.round() - years with ZonedDateTime relativeTo in Temporal.Duration.p.total() - property Gets on receiver in Temporal.PlainDateTime.p.with() - ZonedDateTime difference methods with largestUnit being a time unit - Duration.compare with no units higher than hours
These should be formatted in the same way that they'd be entered in source code.
Ms2ger
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.