Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to Temporal tests #3819

Merged
merged 4 commits into from
Apr 24, 2023
Merged

Improvements to Temporal tests #3819

merged 4 commits into from
Apr 24, 2023

Commits on Apr 22, 2023

  1. Temporal: Fix .slice() in test leftover from debugging 

    I had been using slice() here to cut down the list of operations to
compare during debugging, but accidentally left it in.
    @ptomato
    ptomato committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    ee7d022 View commit details
    Browse the repository at this point in the history

  2. Temporal: More baseline order-of-operations tests 

    Add order-of-operations tests for:

- Temporal.ZonedDateTime.p.getISOFields()
- Temporal.ZonedDateTime.p.round()
- years with ZonedDateTime relativeTo in Temporal.Duration.p.round()
- years with ZonedDateTime relativeTo in Temporal.Duration.p.total()
- property Gets on receiver in Temporal.PlainDateTime.p.with()
- ZonedDateTime difference methods with largestUnit being a time unit
- Duration.compare with no units higher than hours
    @ptomato
    ptomato committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    a327e34 View commit details
    Browse the repository at this point in the history

  3. Improve comments and assertion messages

    @ptomato
    ptomato committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    c2d22e8 View commit details
    Browse the repository at this point in the history

  4. Improve printing of property key names in observer helpers 

    These should be formatted in the same way that they'd be entered in source
code.
    @ptomato
    ptomato committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    ae4fed4 View commit details
    Browse the repository at this point in the history