This repository has been archived by the owner on Sep 4, 2024. It is now read-only.
Rename types #10
Merged
Rename types #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Macros should use `$crate` in the path.
The `hmac` types are named differently to the other hash types. At this stage there is not that much difference between them and it is not immediately obvious why they get a different naming scheme. As we do for the other hash types use `Hash` and `HashEngine` with the expectation that user differentiate by using the module path. With this patch applied users use `hmac::Hash` instead of `Hmac`.
tcharding
force-pushed
the
05-14-rename
branch
2 times, most recently
from
bf5393d
to
bad37a9
Compare
Currently we use the same name for the hash engine trait and the structs in each module. There is no real additional information in, for example, `sha256::HashEngine` compared to `sha256::Engine`. Use the more terse `Engine` and remove the overloading of the term.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done in two parts:
HmacandHmacEnginetypes toHashandHashEngineHashEnginetypes to plain oldEngine(Patch 1 is a trivial cleanup.)