Skip to content
This repository has been archived by the owner on Sep 4, 2024. It is now read-only.

Rename types #10

Merged
merged 3 commits into from
May 14, 2024
Merged

Rename types #10

merged 3 commits into from
May 14, 2024

Commits on May 14, 2024

  1. Use $crate in macros 

    Macros should use `$crate` in the path.
    @tcharding
    tcharding committed May 14, 2024
    Configuration menu
    Copy the full SHA
    b257a6c View commit details
    Browse the repository at this point in the history

  2. Rename hmac types 

    The `hmac` types are named differently to the other hash types. At this
stage there is not that much difference between them and it is not
immediately obvious why they get a different naming scheme.

As we do for the other hash types use `Hash` and `HashEngine` with the
expectation that user differentiate by using the module path.

With this patch applied users use `hmac::Hash` instead of `Hmac`.
    @tcharding
    tcharding committed May 14, 2024
    Configuration menu
    Copy the full SHA
    5ebfa0f View commit details
    Browse the repository at this point in the history

  3. Rename HashEngine structs to Engine 

    Currently we use the same name for the hash engine trait and the structs
in each module. There is no real additional information in, for example,
`sha256::HashEngine` compared to `sha256::Engine`. Use the more terse
`Engine` and remove the overloading of the term.
    @tcharding
    tcharding committed May 14, 2024
    Configuration menu
    Copy the full SHA
    d9973ac View commit details
    Browse the repository at this point in the history