-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec compliance (--platform
)
#209
Comments
It's a known mistake, see #120 and #106 (comment). We wanted to make the move to another argument parsing lib once its new major release comes out (and fix some flags while we are at it), but it is taking a lot longer than anticipated. I think we could still fix this in the next release, we already have breaking changes for one flag. @dbrgn ? |
👍 for fitting spec, makes documentation easier and everyone being able to use the same provided information. |
Things to change in order to conform to the client specification:
|
Should we convert your list to issues with a custom label / milestone? |
Sure, why not 🙂 Edit: I decided to send PRs instead of opening issues 😄 |
I decided to drop the issue with the platform type "all" from the spec compliance list, since its place in the spec is disputed (see tldr-pages/tldr#7528 and tldr-pages/tldr#7561). We'll keep tracking those issues, but the compliance work for the client specification v1.5 is done here, I think. |
this has already caused a lot of confusion (tldr-pages/tldr#6869, tldr-pages/tldr#9252 (review), …), is not standard (https://github.com/tldr-pages/tldr/blob/9ac1ffd5ca55f977da63d954788be5c463def51a/CLIENT-SPECIFICATION.md#arguments) and has already been fixed in other clients (tealdeer-rs/tealdeer#209)
We recently had some internal misconceptions (tldr-pages/tldr#6869) because of clients, especially this one, not complying to the spec by using
-o
/--os
instead of-p
/--platform
. Is that only because of--pager
and are you planning to fix it?Things to change in order to conform to the client specification:
-o
/--os
to-p
/--platform
→ Rename-o / --os
to-p / --platform
#217tldr AbC should display the page called
abc`) → Lowercase page names before lookup #227Support the platformall
which works like the default platform, but lists pages from all platforms when calling--list
→ Support platform type "all" #229The text was updated successfully, but these errors were encountered: