Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec compliance (--platform) #209

Closed
2 of 3 tasks
pixelcmtd opened this issue Oct 8, 2021 · 6 comments
Closed
2 of 3 tasks

Spec compliance (--platform) #209

pixelcmtd opened this issue Oct 8, 2021 · 6 comments
Milestone

Comments

@pixelcmtd
Copy link

pixelcmtd commented Oct 8, 2021

We recently had some internal misconceptions (tldr-pages/tldr#6869) because of clients, especially this one, not complying to the spec by using -o/--os instead of -p/--platform. Is that only because of --pager and are you planning to fix it?

Things to change in order to conform to the client specification:

@niklasmohrin
Copy link
Collaborator

It's a known mistake, see #120 and #106 (comment). We wanted to make the move to another argument parsing lib once its new major release comes out (and fix some flags while we are at it), but it is taking a lot longer than anticipated. I think we could still fix this in the next release, we already have breaking changes for one flag. @dbrgn ?

@niklasmohrin niklasmohrin added this to the v1.5.0 milestone Oct 9, 2021
@CleanMachine1
Copy link

👍 for fitting spec, makes documentation easier and everyone being able to use the same provided information.

@dbrgn
Copy link
Collaborator

dbrgn commented Oct 16, 2021

Things to change in order to conform to the client specification:

  • Rename -o --os to -p --platform
  • When doing a page lookup, ensure that the page name must be lowercased (e.g. tldr eyeD3 should return the page called eyed3)
  • Low prio: Support the platform all which works like the default platform, but lists pages from all platforms when calling --list

@niklasmohrin
Copy link
Collaborator

Should we convert your list to issues with a custom label / milestone?

@dbrgn
Copy link
Collaborator

dbrgn commented Oct 17, 2021

Sure, why not 🙂

Edit: I decided to send PRs instead of opening issues 😄

@dbrgn
Copy link
Collaborator

dbrgn commented Dec 19, 2021

I decided to drop the issue with the platform type "all" from the spec compliance list, since its place in the spec is disputed (see tldr-pages/tldr#7528 and tldr-pages/tldr#7561). We'll keep tracking those issues, but the compliance work for the client specification v1.5 is done here, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants