Rename -o / --os to -p / --platform
#217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasmohrin
previously requested changes
Oct 18, 2021
dbrgn
requested review from
niklasmohrin
and removed request for
niklasmohrin
niklasmohrin
reviewed
Dec 5, 2021
This makes it compliant with the client spec. The `-p` flag was previously used for the pager, using the pager now requires using the long flag (`--pager`). Alternatively the pager can be configured through the config file. This commit also renames OsType to PlatformType.
niklasmohrin
approved these changes
Dec 5, 2021
dbrgn
added a commit
that referenced
this pull request
Dec 5, 2021
I missed some occurrences in #217.
dbrgn
added a commit
that referenced
this pull request
Dec 5, 2021
I missed some occurrences in #217.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it compliant with the client spec (see #209).
The
-pflag was previously used for the pager, using the pager now requires using the long flag (--pager). Alternatively the pager can be configured through the config file.