Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing paths for automation #191

Merged
merged 3 commits into from
Apr 18, 2024
Merged

add missing paths for automation #191

merged 3 commits into from
Apr 18, 2024

Conversation

linglejack06
Copy link
Contributor

Summary: Add missing path planner paths to facilitate full automation of tele-op

@linglejack06
Copy link
Contributor Author

@jkleiber would it make sense to move the driveTo methods to a command file? I just feel like we could separate some to make drive class a little smaller? Or would that not work since it has to be in drive class

also could you let me know if I did the path right? i have never used the path planner GUI

@jkleiber
Copy link
Member

@linglejack06 my preference for now is to keep these driveTo methods in the subsystem rather than creating specific commands. The reason being that I think it's better to keep everything centralized in relevant subsystems and then use InstantCommands to trigger these behaviors.

I can take a look at the path today at shop, I imagine it would be a short path that helps the robot approach the source - in the future it is helpful to post a screenshot of the path

@linglejack06
Copy link
Contributor Author

Okay that makes sense

That's the path I added so it should work as long as I got the rotation aspect correct

Copy link
Member

@jkleiber jkleiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it

@linglejack06 linglejack06 merged commit 3990770 into main Apr 18, 2024
3 checks passed
@linglejack06 linglejack06 deleted the otf-path-generation branch April 18, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants