Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add(prebundle): scope aspect #8028

Merged
merged 5 commits into from
Oct 16, 2023
Merged

add(prebundle): scope aspect #8028

merged 5 commits into from
Oct 16, 2023

Conversation

leimonio
Copy link
Contributor

Proposed Changes

  • bare scope bit start - serve from bundle
  • Enable pre-bundling for scope aspect
  • Generate 2 bundles - one for the workspace and another one for the scope
  • Load respective bundle depending on where the dev server is starting (workspace or scope)

GiladShoham
GiladShoham requested changes Oct 15, 2023
View reviewed changes
scopes/ui-foundation/ui/bundle-ui.task.ts Outdated Show resolved Hide resolved
scopes/ui-foundation/ui/bundle-ui.task.ts Outdated Show resolved Hide resolved
scopes/ui-foundation/ui/ui.main.runtime.ts Outdated Show resolved Hide resolved
@GiladShoham GiladShoham merged commit 4fd6c44 into master Oct 16, 2023
@GiladShoham GiladShoham deleted the feat/prebundle-scope-aspect branch October 16, 2023 11:38
@commit-lint commit-lint bot mentioned this pull request Oct 16, 2023
Closed
@GiladShoham GiladShoham mentioned this pull request Oct 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiladShoham GiladShoham GiladShoham approved these changes

@guysaar223 guysaar223 Awaiting requested review from guysaar223

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leimonio @GiladShoham