[pull] master from teambit:master #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
|
No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews. |
Features
Add
Bug Fixes
Improvement
Chore
Contributorszkochan, leimonio, NitsanCohen770, luvkapur, davidfirst, ranm8, GiladShoham Commit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
👋 Hi there!
|
|
Please remove the sponsorship link in the pull request body to keep the focus on the code changes. |
Apply Sweep Rules to your PR?
|
Pull Request ReviewHey there! 👋 I see you've made some changes to the code and you want a review. Let's dive into it! ChangesHere are the major changes made in the code:
SuggestionsHere are some suggestions to improve the code:
BugsHere are the potential bugs found in the code:
ImprovementsHere are the places in the code that could be refactored for better readability:
RatingOn a scale of 0 to 10, here's the rating for the code based on criteria like readability, performance, and security:
That's it for the review! Let me know if you need any further assistance. Good luck with your pull request! 🚀 |
|
Important Auto Review SkippedBot user detected. To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
…mote-lane (#8454) Here is a scenario where this was an issue: `scope-a/comp` was imported to the workspace, a new lane was created on another scope: `scope-b/dev` and this component was changed and snapped so it became part of the lane. Then, `bit reset` was running which changed the head on the lane to be the same as main. Now `bit export` throws an error saying `scope-a/comp` doesn't exist. This is because the lane-object included this component but this component wasn't sent to the remote as it wasn't staged. This PR fixes it by removing the component from the lane during the reset command. Because the component doesn't exist on the remote-lane and its head is the same as main, no reason to keep it on the lane.
Currently, `bit scope rename` supports only new components. For exported, it suggests users to run `bit rename` one by one, which can be an hassle. This PR combines the logic from "rename", "renameScope" and "renameOwner" to one place "renameMultiple" and allows renaming multiple components, some can be exported, some can be new. Previously, some of the actions during the rename were done only on "rename" or only on "renameScope", now all of them are aligned.
This PR fixes the rendering of Code Compare route by handling the monaco editor being lazily imported via context. Since, monaco editor is now lazily imported - it was unavailable during the first phase of the render cycle, which caused an exception to be thrown when calculating the height of the container.
Update legacy-bit-id component to 1.1.1 which includes `BitIds` class. With this in place, no need for BitId directory anymore, both BitId and BitIds classes can be consumed from legacy-bit-id component.
… relevant for TS components (#8451)
… in the lane history (#8465)
## Proposed Changes - remove ink from all services - remove ink from test cmd - remove unused time component - remove unused EnvConsole component - remove ink from run.cmd
…escript-compiler (#8632)
…olbox/array/duplications-finder" (#8635)
## Proposed Changes - remove ink completely - remove commands' render method support - update lib in aspect env tsconfig to ES2022 - remove ink from the start command - logger new APIs - isSpinning and multiSpinner - improve webpack events listener - add new dep - dreidels": "0.6.1" - improve `bit start` outputs (especially errors/warnings handling) - cleanups (remove) unused components - improve cli docs (remove ink label)
…box/fs/link-or-symlink (#8637) The name is changed as well because it doesn't do copy anymore. It only links (hard) or symlink.
…m an internal dir (#8634) Also, don't allow running `bit init` without flags in a nested directory. The user intention is probably to create a new workspace, not fixing the current one.
…ame and the scope (#8636)
- update typescript package to 5.3.3 - fix lots of errors from "tsc" due to breaking changes introduced in version 5. - update eslint packages to support the new version of typescript. - update prettier to support the new syntax of "import type". - fix new lint errors due to the upgrade of the eslint and some eslint plugins. - increate the memory of CircleCI for "lint" job. It's now reaches around 2.5GB.
`teambit.scope/modules/find-scope-path`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )