Fix missing data bug #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove extra `a`
Fix a minor typo in Readme
Add example in README for setting default values
Add test to check no line is forgotten when copying 5 lines with stride 2
…nker Fix chunker for forgotten lines
MatiasFernandez
requested review from
goodgravy,
JavierGelatti,
niklasnordlund,
RTakes,
timminkov,
julianGallegos and
angeles-tellaarena
MatiasFernandez
force-pushed
the
fix-missing-data-bug
branch
from
27a5fc2 to
d0bb55b
Compare
JuanFdS
approved these changes
May 7, 2019
angeles-tellaarena
approved these changes
May 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
During my work of making migrations resumable I've found a bug that causes LHM to skip copying the last row of a table in certain cases
Solution
Soundcloud's master branch includes a fix for that issue. I backported it to our fork