Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tww_symbology_inflow_prio #538

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

cymed
Copy link
Contributor

@cymed cymed commented Jan 22, 2025

When handling discharge points into culverted water bodies, we want the symbology to be "green" instead of "blue". Therefore, we have anadditional field tww_symbology_inflow_prio, Theis field was mistakenly created on function_hierachic instead of usage_current. This PR fixes that

the additional field  tww_symbology_inflow_prio should be on usage_current instead of function_hierarchic
@cymed cymed self-assigned this Jan 22, 2025
@cymed cymed closed this Jan 22, 2025
@cymed cymed reopened this Jan 22, 2025
@sjib
Copy link
Contributor

sjib commented Jan 22, 2025

@urskaufmann is this change correct?

@cymed
Copy link
Contributor Author

cymed commented Jan 23, 2025

          > Labeling is ok Symbology: I'm not sure. Manhole symbology depends on the connected channels. First prio: outlet-channel (outlet of the main node). If there are 2/more outlets (which is really an exception), then it's the PAA-channel, that matters. If there are 2/more outlet-PAA-Channels, then it's the usage_current (tww_symbology_order in tww_vl.channel_usage_current). If there is no outlet, then it depends on the inlets and here again the same rules: first PAA before SAA, then usage_current with the same prio as in the outlet case. I do not see the case when to use a separate inflow_prio.

Symbology is exactly what is currently implemented. We prioritise inflowing channels with discharged wastewater over outflows so we can symbolise discharge points into culverted water bodies with the _usage_current "discharged_wastewater". If there is no incoming channel with discharged wastewater, we prioritise by outgoing over incoming and function_hierarchic over usage_current

Originally posted by @cymed in #539 (comment)

@cymed cymed requested a review from sjib January 23, 2025 08:45
@cymed
Copy link
Contributor Author

cymed commented Jan 23, 2025

@urskaufmann is this change correct?

#539 (comment)_

Copy link
Contributor

@sjib sjib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - thanks!

@cymed cymed merged commit 9cc24a7 into teksi:main Feb 4, 2025
7 checks passed
@cymed cymed deleted the fix-tww_symbology_inflow_prio- branch February 4, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants