Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add label and symbology custiomisation guide to docs #539

Merged
merged 4 commits into from
Jan 24, 2025

Conversation

cymed
Copy link
Contributor

@cymed cymed commented Jan 22, 2025

No description provided.

@cymed cymed added the documentation Improvements or additions to documentation label Jan 22, 2025
@cymed cymed self-assigned this Jan 22, 2025
@cymed cymed requested a review from urskaufmann January 22, 2025 12:35
@cymed cymed linked an issue Jan 22, 2025 that may be closed by this pull request
@urskaufmann
Copy link
Contributor

Labeling is ok
Symbology: I'm not sure. Manhole symbology depends on the connected channels. First prio: outlet-channel (outlet of the main node). If there are 2/more outlets (which is really an exception), then it's the PAA-channel, that matters. If there are 2/more outlet-PAA-Channels, then it's the usage_current (tww_symbology_order in tww_vl.channel_usage_current).
If there is no outlet, then it depends on the inlets and here again the same rules: first PAA before SAA, then usage_current with the same prio as in the outlet case. I do not see the case when to use a separate inflow_prio.

@cymed
Copy link
Contributor Author

cymed commented Jan 23, 2025

Labeling is ok Symbology: I'm not sure. Manhole symbology depends on the connected channels. First prio: outlet-channel (outlet of the main node). If there are 2/more outlets (which is really an exception), then it's the PAA-channel, that matters. If there are 2/more outlet-PAA-Channels, then it's the usage_current (tww_symbology_order in tww_vl.channel_usage_current). If there is no outlet, then it depends on the inlets and here again the same rules: first PAA before SAA, then usage_current with the same prio as in the outlet case. I do not see the case when to use a separate inflow_prio.

Symbology is exactly what is currently implemented. We prioritise inflowing channels with discharged wastewater over outflows so we can symbolise discharge points into culverted water bodies with the _usage_current "discharged_wastewater". If there is no incoming channel with discharged wastewater, we prioritise by outgoing over incoming and function_hierarchic over usage_current

@urskaufmann
Copy link
Contributor

OK like this. Till now I have never had a discharge_point with outlet. But may happen...

@cymed cymed requested review from sjib and removed request for urskaufmann January 23, 2025 08:44
@cymed cymed merged commit c96d180 into teksi:main Jan 24, 2025
3 checks passed
@cymed cymed deleted the add-customisation-docs branch January 31, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Labeling SAA
3 participants