Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add securityContext to controller pod #346

Merged
merged 1 commit into from
Jan 27, 2022

Commits on Jan 21, 2022

  1. Add securityContext to controller pod

    This commit adds securityContext to the controller pod which has been
    missing till now. This is in line with securityContext in other Tekton
    components like pipeline and triggers.
    
    There are a few reasons why securityContext is important to add to the
    controller:
    - the securityContext specifies the user and group as 65532 which is
      what is used by the distroless nonroot image that ko uses in the
      controller image.
    - securityContext is also useful in distributions like OpenShift which
      assign a random user while running a pod. If securityContext is not
      set, the controller fails with permission denied errors like in tektoncd#320
    concaf committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    b5031b7 View commit details
    Browse the repository at this point in the history