Add Tekton Design Principles #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/S
ghost
approved these changes
Aug 10, 2020
vdemeester
reviewed
Aug 11, 2020
dlorenc
reviewed
Aug 16, 2020
jerop
force-pushed
the
tekton-design-principles
branch
from
3109b9a to
07e30c7
Compare
|
/lgtm |
|
I'm very excited! Any thoughts I had were addressed in the original doc so: /lgtm Waiting for review from @vdemeester @afrittoli (and anyone/everyone else who would like to chime in of course) before merging |
afrittoli
reviewed
Sep 8, 2020
jerop
force-pushed
the
tekton-design-principles
branch
from
07e30c7 to
8105454
Compare
afrittoli
reviewed
Sep 21, 2020
This builds on the [API Design section](https://github.com/tektoncd/community/pull/133/files#diff-11ec7b2edcebbbc9374c04b87a8e7dd9R80) of the [Tekton contributor and reviewer expectations](tektoncd#133). The goal of these principles is to provide a basis for design choices and help in making tradeoffs. The design principles are reusability, simplicity, flexibility and conformance. The principles were initially proposed in [this Google Doc](https://docs.google.com/document/d/1_iqwslxAOx-SPYosnTFS5kOZcmxcBWpuIULZHQHP85Q/edit?usp=sharing) that's visible to members of tekton-dev@.
jerop
force-pushed
the
tekton-design-principles
branch
from
8105454 to
478454b
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
|
Hey @jerop , just realized we didn't add any links to this - can we add a link from the main README? |
jerop
added a commit
to jerop/community
that referenced
this pull request
Nov 3, 2020
We added design principles in tektoncd#171 Adding a reference to them to increase the visibility to contributors
jerop
added a commit
to jerop/community
that referenced
this pull request
Nov 3, 2020
We added design principles in tektoncd#171 Adding a reference to them to increase the visibility to contributors
jerop
added a commit
to jerop/community
that referenced
this pull request
Nov 3, 2020
We added design principles in tektoncd#171 Adding a reference to them to increase the visibility to contributors
tekton-robot
pushed a commit
that referenced
this pull request
Nov 3, 2020
We added design principles in #171 Adding a reference to them to increase the visibility to contributors
bobcatfish
added a commit
to bobcatfish/pipeline
that referenced
this pull request
Dec 9, 2020
@jerop has been reviewed 32 PRs in pipelines (https://github.com/tektoncd/pipeline/pulls?q=is%3Apr+reviewed-by%3Ajerop+-author%3Ajerop) and has authored 27 PRs against this repo (https://github.com/tektoncd/pipeline/pulls/jerop) including when expressions tektoncd#3135, in addition to making significant improvements to our processes (e.g. defining design principles tektoncd/community#171 and recently proposing topical areas of ownership) Thanks for all your hard work @jerop!!
2 tasks
tekton-robot
pushed a commit
to tektoncd/pipeline
that referenced
this pull request
Dec 9, 2020
@jerop has been reviewed 32 PRs in pipelines (https://github.com/tektoncd/pipeline/pulls?q=is%3Apr+reviewed-by%3Ajerop+-author%3Ajerop) and has authored 27 PRs against this repo (https://github.com/tektoncd/pipeline/pulls/jerop) including when expressions #3135, in addition to making significant improvements to our processes (e.g. defining design principles tektoncd/community#171 and recently proposing topical areas of ownership) Thanks for all your hard work @jerop!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of these principles is to provide a basis for design choices and help in making tradeoffs. The design principles are reusability, simplicity, flexibility and conformance.
The principles were initially proposed and discussed in this google doc that's visible to members of tekton-dev@. Thank you for the contributions!
Related issue: Add contributor and reviewer expectations.