-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error showing TaskRun steps that have not run #653
Conversation
/uncc @dibbles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not hide steps that have not executed, and the current behaviour where we do not display Task(Run)s that have not begun executing is a known issue we've been tracking for a while.
When we introduce the pipeline diagram we will display all nodes, decorated appropriately to indicate their status.
A fix for #644 should ensure steps that have not run are displayed as such, the component already supports this state, we may need to make some minor changes to ensure the correct props are passed to render this as expected: https://alangreene.github.io/dashboard/?path=/story/step--default
Thanks for the feedback @AlanGreene! I'll update this PR to show the default step state instead of hiding the steps 👍 |
/hold cancel |
src/utils/index.js
Outdated
return steps; | ||
} | ||
let errorIndex = steps.length - 1; | ||
return steps.map((step, index) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's worth raising tektoncd/pipeline#1439 in the next working group meeting at least to ask for feedback on the issue.
It also looks like the behaviour when cancelling a PipelineRun is different, I see steps marked as Waiting instead of Completed. Maybe this would be more appropriate than Error?
Having this workaround in the dashboard for now resolves the immediate user-facing issue for users of the dashboard, but users of kubectl or other tools still have the same misleading information presented (i.e. a step that hasn't executed is marked as Completed), and each tool needs to handle this themselves.
@ncskier can you also update the PR title + description to reflect the change in approach taken here? Looks like the commit message is already updated. Thanks |
7bb486c
to
b927224
Compare
Thanks for the feedback @AlanGreene! I've updated the PR title & description, and I think I've addressed all of your concerns. Let me know if there's anything else that I can do 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost there, just a couple of imports that need updating to reference the utils package instead
Fixes tektoncd#644 This fix shows a neutral "Not run" status for steps that follow a step with an error. Previously, these steps showed a misleading green "Completed" status.
Ah, thanks @AlanGreene! I just fixed the imports 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for making those changes 👍
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlanGreene The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This reverts commit c1aa3e4. Reverts tektoncd#653 Tekton Pipelines now correctly sets the status of skipped steps tektoncd/pipeline#1439
This reverts commit c1aa3e4. Reverts #653 Tekton Pipelines now correctly sets the status of skipped steps tektoncd/pipeline#1439
This fixes the error seen when using the Tekton Dashboard with Tekton Pipelines v0.8.0. In order to support users on Tekton Pipelines v0.8.0 and earlier, the fix from tektoncd#653 is going back into the Dashboard codebase. The fix was previously reverted when Tekton Pipelines v0.9.0 fixed the root cause of the issue (https://github.com/tektoncd/dashboard/pull/795/files).
This fixes an error seen when using the Tekton Dashboard with Tekton Pipelines v0.8.0. In order to support users on Tekton Pipelines v0.8.0 and earlier, the fix from tektoncd#653 is going back into the Dashboard codebase. The fix was previously reverted when Tekton Pipelines v0.9.0 fixed the root cause of the issue (https://github.com/tektoncd/dashboard/pull/795/files).
This fixes an error seen when using the Tekton Dashboard with Tekton Pipelines v0.8.0. In order to support users on Tekton Pipelines v0.8.0 and earlier, the fix from #653 is going back into the Dashboard codebase. The fix was previously reverted when Tekton Pipelines v0.9.0 fixed the root cause of the issue (https://github.com/tektoncd/dashboard/pull/795/files).
Changes
Fixes #644
This fix shows a neutral "Not run" status for steps that follow a step with an
error. Previously, these steps showed a misleading green "Completed" status.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.